From: Logan Gunthorpe <logang@deltatee.com>
To: Matthew Wilcox <willy@infradead.org>, Martin Mares <mj@ucw.cz>
Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
linux-doc@vger.kernel.org, "Stephen Bates" <sbates@raithlin.com>,
"Christoph Hellwig" <hch@lst.de>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Jonathan Corbet" <corbet@lwn.net>,
"Ingo Molnar" <mingo@kernel.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
"Marc Zyngier" <marc.zyngier@arm.com>,
"Kai-Heng Feng" <kai.heng.feng@canonical.com>,
"Frederic Weisbecker" <frederic@kernel.org>,
"Dan Williams" <dan.j.williams@intel.com>,
"Jérôme Glisse" <jglisse@redhat.com>,
"Benjamin Herrenschmidt" <benh@kernel.crashing.org>,
"Alex Williamson" <alex.williamson@redhat.com>,
"Christian König" <christian.koenig@amd.com>
Subject: Re: lspci: Display path to device
Date: Tue, 17 Jul 2018 14:51:40 -0600 [thread overview]
Message-ID: <1e1f1e0d-520a-e2f9-15cb-09e97cd4a836@deltatee.com> (raw)
In-Reply-To: <20180717203900.GA1771@bombadil.infradead.org>
On 17/07/18 02:39 PM, Matthew Wilcox wrote:
> On Tue, Jul 17, 2018 at 11:02:00AM -0600, Logan Gunthorpe wrote:
>> The second patch expands the new helper to optionally take a path of
>> PCI devfns. This is to address Alex's renumbering concern when using
>> simple bus-devfns. The implementation is essentially how he described it and
>> similar to the Intel VT-d spec (Section 8.3.1).
>
> I don't like telling the user to grovel around lspci -t by hand. It's
> not many lines of code to add a new -P option to lspci to show the path
> to each device instead of bus:dev.fn
Thanks, this looks great! I also found parsing the lspci -t output
cumbersome.
I've also got patches pending for switchtec-user[1] that help users find
the path of downstream ports for Microsemi switches. (An example is
shown below). As the ACS feature is primarily for PCI switch users, this
should help a good segment of people. The lspci patches should cover a
lot more people though.
Logan
sudo switchtec status /dev/switchtec0 -v
Partition 0: (LOCAL)
Logical Port ID 0 (USP):
Phys Port ID: 32 (Stack 4, Port 0)
Bus-Dev-Func: 0000:02:00.0
Bus-Dev-Func Path: 0000:00:02:0/00.0
Status: UP
LTSSM: L0
Max-Width: x16
Neg Width: x16
Rate: Gen3 - 8 GT/s 15.76 GB/s
Out Bytes: 70.3 GB
In Bytes: 70.8 GB
Logical Port ID 1 (DSP):
Phys Port ID: 8 (Stack 1, Port 0)
Bus-Dev-Func: 0000:03:00.0
Bus-Dev-Func Path: 0000:00:02:0/00.0/00.0
Status: UP
LTSSM: L0
Max-Width: x8
Neg Width: x8
Rate: Gen3 - 8 GT/s 7.88 GB/s
Out Bytes: 12.2 MB
In Bytes: 441 MB
ACS: SrcValid- TransBlk- ReqRedir- CmpltRedir-
UpstreamFwd- EgressCtrl- DirectTrans-
Device: 10b5:8724 (0000:04:00.0)
0000:05
Logical Port ID 2 (DSP):
Phys Port ID: 12 (Stack 1, Port 4)
Bus-Dev-Func: 0000:03:01.0
Bus-Dev-Func Path: 0000:00:02:0/00.0/01.0
Status: UP
LTSSM: L0
Max-Width: x8
Neg Width: x8
Rate: Gen3 - 8 GT/s 7.88 GB/s
Out Bytes: 1.65 MB
In Bytes: 107 MB
ACS: SrcValid- TransBlk- ReqRedir- CmpltRedir-
UpstreamFwd- EgressCtrl- DirectTrans-
Device: 11f8:f117 (0000:0b:00.0)
nvme4
[1] https://github.com/Microsemi/switchtec-user/pull/25
next prev parent reply other threads:[~2018-07-17 21:26 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-17 17:02 [PATCH v7 0/4] Add parameter for disabling ACS redirection for P2P Logan Gunthorpe
2018-07-17 17:02 ` [PATCH v7 1/4] PCI: Make specifying PCI devices in kernel parameters reusable Logan Gunthorpe
2018-07-17 17:02 ` [PATCH v7 2/4] PCI: Allow specifying devices using a base bus and path of devfns Logan Gunthorpe
2018-07-17 17:02 ` [PATCH v7 3/4] PCI: Introduce disable_acs_redir quirk Logan Gunthorpe
2018-07-17 17:48 ` Alex Williamson
2018-07-17 17:02 ` [PATCH v7 4/4] PCI: Introduce the disable_acs_redir parameter Logan Gunthorpe
2018-07-17 17:48 ` Alex Williamson
2018-07-17 17:49 ` Logan Gunthorpe
2018-07-17 17:57 ` Stephen Bates
2018-07-17 20:39 ` lspci: Display path to device Matthew Wilcox
2018-07-17 20:51 ` Logan Gunthorpe [this message]
2018-07-17 21:00 ` Bjorn Helgaas
2018-07-17 21:46 ` Matthew Wilcox
2018-08-09 23:48 ` Matthew Wilcox
2018-08-10 9:35 ` Martin Mares
2018-08-10 10:30 ` Martin Mares
2018-08-10 14:56 ` Matthew Wilcox
2018-08-12 9:28 ` Martin Mares
2018-08-12 10:31 ` Matthew Wilcox
2018-08-12 10:51 ` Martin Mares
2018-08-13 15:55 ` Logan Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e1f1e0d-520a-e2f9-15cb-09e97cd4a836@deltatee.com \
--to=logang@deltatee.com \
--cc=alex.williamson@redhat.com \
--cc=benh@kernel.crashing.org \
--cc=bhelgaas@google.com \
--cc=christian.koenig@amd.com \
--cc=corbet@lwn.net \
--cc=dan.j.williams@intel.com \
--cc=frederic@kernel.org \
--cc=hch@lst.de \
--cc=jglisse@redhat.com \
--cc=kai.heng.feng@canonical.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mingo@kernel.org \
--cc=mj@ucw.cz \
--cc=paulmck@linux.vnet.ibm.com \
--cc=sbates@raithlin.com \
--cc=tglx@linutronix.de \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).