linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vidya Sagar <vidyas@nvidia.com>
To: Sathyanarayanan Kuppuswamy 
	<sathyanarayanan.kuppuswamy@linux.intel.com>,
	Bjorn Helgaas <helgaas@kernel.org>
Cc: bhelgaas@google.com, ruscur@russell.cc, oohall@gmail.com,
	treding@nvidia.com, jonathanh@nvidia.com, mmaddireddy@nvidia.com,
	kthota@nvidia.com, linux-pci@vger.kernel.org,
	linux-kernel@vger.kernel.org, vsethi@nvidia.com,
	linuxppc-dev@lists.ozlabs.org, sagar.tv@gmail.com
Subject: Re: [PATCH V1] PCI/AER: Configure ECRC only AER is native
Date: Thu, 12 Jan 2023 12:42:54 +0530	[thread overview]
Message-ID: <1f1b328d-9324-dac9-a59c-13b5cda0bc8e@nvidia.com> (raw)
In-Reply-To: <0406e96b-56fc-d9bd-6ef8-88157ce64e1f@linux.intel.com>



On 1/12/2023 10:36 AM, Sathyanarayanan Kuppuswamy wrote:
> External email: Use caution opening links or attachments
> 
> 
> On 1/11/23 8:59 PM, Vidya Sagar wrote:
>>
>>
>> On 1/12/2023 9:18 AM, Sathyanarayanan Kuppuswamy wrote:
>>> External email: Use caution opening links or attachments
>>>
>>>
>>> On 1/11/23 7:33 PM, Vidya Sagar wrote:
>>>> I think we still need bios option. For example, consider a system where BIOS needs to keep ECRC enabled for integrity reasons but if kernel doesn't want it for perf reasons, then, kernel can always use 'ecrc=off' option.
>>>
>>> I agree that "on" and "off" option makes sense. Since the kernel defaults ecrc setting to "bios", why again allow it as a command line option?
>>
>> Agree. "on" and "off" are fine but "default" is redundant. Do you want me to push a change to remove that as part of this patch itself? I think
>> it is more like a cleanup and should go separately.
> 
> IMO, the "bios" option cleanup and command line update from Bjorn can be in one patch, and your change could be a separate patch. But it is
> up to you and Bjorn.

I think Bjorn's command line suggestion should go along with my patch 
otherwise the ECRC control through command line doesn't work if OS 
doesn't own the AER. So, it helps to make it explicit that the 'ecrc=' 
option works only if either kernel has native AER control or 
'pcie_ports' is set to 'native'

> 
>>
>>>
>>> --
>>> Sathyanarayanan Kuppuswamy
>>> Linux Kernel Developer
> 
> --
> Sathyanarayanan Kuppuswamy
> Linux Kernel Developer

  reply	other threads:[~2023-01-12  7:13 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-11 20:31 [PATCH V1] PCI/AER: Configure ECRC only AER is native Vidya Sagar
2023-01-11 21:42 ` Sathyanarayanan Kuppuswamy
2023-01-11 23:10   ` Bjorn Helgaas
2023-01-11 23:27     ` Sathyanarayanan Kuppuswamy
2023-01-12  3:33       ` Vidya Sagar
2023-01-12  3:48         ` Sathyanarayanan Kuppuswamy
2023-01-12  4:59           ` Vidya Sagar
2023-01-12  5:06             ` Sathyanarayanan Kuppuswamy
2023-01-12  7:12               ` Vidya Sagar [this message]
2023-01-12 18:23       ` Bjorn Helgaas
2023-01-12  7:21 ` [PATCH V2] " Vidya Sagar
2023-01-12 18:25   ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1f1b328d-9324-dac9-a59c-13b5cda0bc8e@nvidia.com \
    --to=vidyas@nvidia.com \
    --cc=bhelgaas@google.com \
    --cc=helgaas@kernel.org \
    --cc=jonathanh@nvidia.com \
    --cc=kthota@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mmaddireddy@nvidia.com \
    --cc=oohall@gmail.com \
    --cc=ruscur@russell.cc \
    --cc=sagar.tv@gmail.com \
    --cc=sathyanarayanan.kuppuswamy@linux.intel.com \
    --cc=treding@nvidia.com \
    --cc=vsethi@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).