From: Myron Stowe <myron.stowe@redhat.com>
To: bhelgaas@google.com
Cc: linux-pci@vger.kernel.org, linux@arm.linux.org.uk,
ralf@linux-mips.org, tglx@linutronix.de, mingo@redhat.com,
hpa@zytor.com, linux-kernel@vger.kernel.org
Subject: [PATCH 1/9] PCI: Remove redundant debug output in pci_do_fixups
Date: Thu, 21 Jun 2012 14:24:23 -0600 [thread overview]
Message-ID: <20120621202423.16865.50394.stgit@amt.stowe> (raw)
In-Reply-To: <20120621202415.16865.6226.stgit@amt.stowe>
When the boot argument 'initcall_debug' is specified, redundant debug
output occurs for each device as a quirk is applied:
...
pci 0000:00:1a.0: calling quirk_usb_early_handoff+0x0/0x620
calling quirk_usb_early_handoff+0x0/0x620 @ 1 for 0000:00:1a.0
pci fixup quirk_usb_early_handoff+0x0/0x620 returned after 32 usecs for 0000:00: 1a.0
...
This patch removes the redundancy by eliminating the first debug output
occurence in the sequence shown above when 'initcall_debug' is specified.
Signed-off-by: Myron Stowe <myron.stowe@redhat.com>
---
drivers/pci/quirks.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
index a2d9d33..9c93558 100644
--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
@@ -2953,11 +2953,12 @@ static void pci_do_fixups(struct pci_dev *dev, struct pci_fixup *f,
f->vendor == (u16) PCI_ANY_ID) &&
(f->device == dev->device ||
f->device == (u16) PCI_ANY_ID)) {
- dev_dbg(&dev->dev, "calling %pF\n", f->hook);
if (initcall_debug)
do_one_fixup_debug(f->hook, dev);
- else
+ else {
+ dev_dbg(&dev->dev, "calling %pF\n", f->hook);
f->hook(dev);
+ }
}
}
next prev parent reply other threads:[~2012-06-21 20:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-21 20:24 [PATCH 0/9] PCI: Add 'pci_fixup_final' quirks into hot-plug paths Myron Stowe
2012-06-21 20:24 ` Myron Stowe [this message]
2012-06-26 22:26 ` [PATCH 1/9] PCI: Remove redundant debug output in pci_do_fixups Bjorn Helgaas
2012-06-28 20:25 ` Myron Stowe
2012-06-21 20:24 ` [PATCH 2/9] PCI: release temporary reference in __nv_msi_ht_cap_quirk() Myron Stowe
2012-06-21 20:24 ` [PATCH 3/9] arm/PCI: move final fixup quirks from __init to __devinit Myron Stowe
2012-06-26 22:33 ` Bjorn Helgaas
2012-06-28 20:25 ` Myron Stowe
2012-06-21 20:24 ` [PATCH 4/9] MIPS/PCI: " Myron Stowe
2012-06-21 20:24 ` [PATCH 5/9] parisc/PCI: " Myron Stowe
2012-06-21 20:24 ` [PATCH 6/9] powerpc/PCI: " Myron Stowe
2012-06-21 20:24 ` [PATCH 7/9] x86/PCI: " Myron Stowe
2012-06-21 20:25 ` [PATCH 8/9] PCI: " Myron Stowe
2012-06-21 20:25 ` [PATCH 9/9] PCI: integrate 'pci_fixup_final' quirks into hot-plug paths Myron Stowe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120621202423.16865.50394.stgit@amt.stowe \
--to=myron.stowe@redhat.com \
--cc=bhelgaas@google.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mingo@redhat.com \
--cc=ralf@linux-mips.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).