From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from e3.ny.us.ibm.com ([32.97.182.143]:35912 "EHLO e3.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755420Ab2FZDBT (ORCPT ); Mon, 25 Jun 2012 23:01:19 -0400 Received: from /spool/local by e3.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 25 Jun 2012 23:01:18 -0400 Received: from d01relay06.pok.ibm.com (d01relay06.pok.ibm.com [9.56.227.116]) by d01dlp01.pok.ibm.com (Postfix) with ESMTP id 83BFE38C8054 for ; Mon, 25 Jun 2012 23:01:16 -0400 (EDT) Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216]) by d01relay06.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q5Q31F3n21299276 for ; Mon, 25 Jun 2012 23:01:15 -0400 Received: from d01av02.pok.ibm.com (loopback [127.0.0.1]) by d01av02.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q5Q31ELC013609 for ; Tue, 26 Jun 2012 00:01:15 -0300 Date: Tue, 26 Jun 2012 11:01:11 +0800 From: Gavin Shan To: Benjamin Herrenschmidt Cc: Gavin Shan , Yinghai Lu , linux-pci@vger.kernel.org, linuxppc-dev@ozlabs.org, bhelgaas@google.com Subject: Re: [PATCH V3 1/2] PCI: retrieve host bridge by PCI bus Message-ID: <20120626030111.GA6753@shangw> Reply-To: Gavin Shan References: <1340593821-19011-1-git-send-email-shangw@linux.vnet.ibm.com> <20120626003020.GA6307@shangw> <1340679045.3732.3.camel@pasglop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1340679045.3732.3.camel@pasglop> Sender: linux-pci-owner@vger.kernel.org List-ID: >> >> +EXPORT_SYMBOL(pci_bus_host_bridge); >> >> Yinghai, thanks for your time on this :-) >> >> > >> >why do you need to export it? >> > >> >> The reason is that we have introduced extra fields to "struct >> pci_host_bridge" >> in [PATCH 2/2] and platform want to access those extra fields. > >But the platform code is built-in, not modular, so it doesn't need >EXPORT_SYMBOL (additionally even if we wanted to export it we probably >also want it _GPL only, so EXPORT_SYMBOL_GPL, but I don't think we need >to). > Ben, thanks for correcting me :-) Let me remove EXPORT_SYMBOL() is next revision. >Cheers, >Ben. > > Thanks, Gavin