From: Jiri Pirko <jiri@resnulli.us>
To: Jon Mason <jon.mason@intel.com>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-pci@vger.kernel.org, Dave Jiang <dave.jiang@intel.com>
Subject: Re: [RFC v2 2/2] net: Add support for NTB virtual ethernet device
Date: Mon, 30 Jul 2012 22:09:05 +0200 [thread overview]
Message-ID: <20120730200905.GA1673@minipsycho.orion> (raw)
In-Reply-To: <20120730181910.GB987@jonmason-lab>
Mon, Jul 30, 2012 at 08:19:11PM CEST, jon.mason@intel.com wrote:
>On Mon, Jul 30, 2012 at 04:02:16PM +0200, Jiri Pirko wrote:
>> Mon, Jul 30, 2012 at 02:26:34AM CEST, jon.mason@intel.com wrote:
>> >+static int __devinit ntb_netdev_probe(struct pci_dev *pdev)
>> >+{
>> >+ struct net_device *ndev;
>> >+ struct ntb_netdev *dev;
>> >+ int rc;
>> >+
>> >+ ndev = alloc_etherdev(sizeof(struct ntb_netdev));
>> >+ if (!ndev)
>> >+ return -ENOMEM;
>> >+
>> >+ dev = netdev_priv(ndev);
>> >+ dev->ndev = ndev;
>> >+ dev->pdev = pdev;
>> >+ BUG_ON(!dev->pdev);
>> >+ ndev->features = NETIF_F_HIGHDMA;
>> >+
>> >+ //ndev->priv_flags |= IFF_LIVE_ADDR_CHANGE;
>> ^^ I guess you forgot to un-comment this.
>
>Oops. An easy fix. Anything else?
The rest looks good to me.
>
>Thanks,
>Jon
next prev parent reply other threads:[~2012-07-30 20:09 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-30 0:26 [RFC v2 0/2] PCI-Express Non-Transparent Bridge Support Jon Mason
2012-07-30 0:26 ` [RFC v2 1/2] " Jon Mason
2012-07-30 16:50 ` Bjorn Helgaas
2012-07-30 18:15 ` Jon Mason
2012-07-31 3:35 ` Jianbin Kang
2012-07-31 16:33 ` Jon Mason
2012-08-01 2:10 ` Jianbin Kang
2012-08-01 2:18 ` Jiang, Dave
2012-07-31 13:45 ` Bjorn Helgaas
2012-07-31 16:02 ` chetan loke
2012-07-31 17:03 ` Bjorn Helgaas
2012-07-31 17:27 ` Jon Mason
2012-07-31 18:02 ` chetan loke
2012-08-02 1:43 ` Jon Mason
2012-07-31 17:10 ` Jon Mason
2012-07-31 16:14 ` chetan loke
2012-07-31 22:23 ` Greg KH
2012-07-31 22:51 ` Jon Mason
2012-07-31 23:14 ` Greg KH
2012-07-31 22:25 ` Greg KH
2012-08-02 1:49 ` Jon Mason
2012-07-30 0:26 ` [RFC v2 2/2] net: Add support for NTB virtual ethernet device Jon Mason
2012-07-30 14:02 ` Jiri Pirko
2012-07-30 18:19 ` Jon Mason
2012-07-30 20:09 ` Jiri Pirko [this message]
2012-07-31 22:28 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120730200905.GA1673@minipsycho.orion \
--to=jiri@resnulli.us \
--cc=dave.jiang@intel.com \
--cc=jon.mason@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).