From: Fengguang Wu <fengguang.wu@intel.com>
To: "Tang, Feng" <feng.tang@intel.com>
Cc: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Steven Rostedt <rostedt@goodmis.org>, Avi Kivity <avi@redhat.com>,
Steven Rostedt <srostedt@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>,
Yinghai Lu <yinghai@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org
Subject: Re: pci_get_subsys: GFP_KERNEL allocations with IRQs disabled
Date: Wed, 22 Aug 2012 10:50:08 +0800 [thread overview]
Message-ID: <20120822025008.GA8066@localhost> (raw)
In-Reply-To: <20120801004319.GA7043@localhost>
Feng,
> I think it's pci_get_subsys() triggered this assert:
>
> /*
> * Oi! Can't be having __GFP_FS allocations with IRQs disabled.
> */
> if (DEBUG_LOCKS_WARN_ON(irqs_disabled_flags(flags)))
> return;
It's bisected down to this commit:
commit 55c844a4dd16a4d1fdc0cf2a283ec631a02ec448
Author: Feng Tang <feng.tang@intel.com>
AuthorDate: Wed May 30 23:15:41 2012 +0800
Commit: Ingo Molnar <mingo@kernel.org>
CommitDate: Wed Jun 6 12:03:23 2012 +0200
x86/reboot: Fix a warning message triggered by stop_other_cpus()
Thanks,
Fengguang
> [ 91.282131] machine restart
> [ 91.283895] ------------[ cut here ]------------
> [ 91.284731] WARNING: at /c/wfg/linux/kernel/lockdep.c:2739 lockdep_trace_alloc+0x1fb/0x210()
> [ 91.286132] Modules linked in:
> [ 91.286703] Pid: 697, comm: reboot Not tainted 3.5.0-00024-g01ff5db-dirty #4
> [ 91.287859] Call Trace:
> [ 91.288289] [<81050148>] warn_slowpath_common+0xb8/0x100
> [ 91.289338] [<8110acdb>] ? lockdep_trace_alloc+0x1fb/0x210
> [ 91.290264] [<8110acdb>] ? lockdep_trace_alloc+0x1fb/0x210
> [ 91.291161] [<810501ce>] warn_slowpath_null+0x3e/0x50
> [ 91.292042] [<8110acdb>] lockdep_trace_alloc+0x1fb/0x210
> [ 91.292934] [<81228e25>] kmem_cache_alloc_trace+0x55/0x600
> [ 91.292934] [<813025ca>] ? kobject_put+0x9a/0x160
> [ 91.292934] [<814e95e0>] ? klist_iter_exit+0x30/0x50
> [ 91.292934] [<81405881>] ? bus_find_device+0xf1/0x120
> [ 91.292934] [<81361a3c>] ? pci_get_subsys+0x11c/0x1b0
> [ 91.292934] [<81361a3c>] pci_get_subsys+0x11c/0x1b0
> [ 91.292934] [<81361afe>] pci_get_device+0x2e/0x40
> [ 91.292934] [<81033e25>] mach_reboot_fixups+0xa5/0xd0
> [ 91.292934] [<81027611>] native_machine_emergency_restart+0x1f1/0x590
> [ 91.292934] [<814f2e00>] ? printk+0x4b/0x5b
> [ 91.292934] [<810269ef>] native_machine_restart+0x6f/0x80
> [ 91.292934] [<810271cc>] machine_restart+0x1c/0x30
> [ 91.292934] [<810886e0>] kernel_restart+0x70/0xc0
> [ 91.292934] [<81088a85>] sys_reboot+0x325/0x380
> [ 91.292934] [<811f796c>] ? handle_pte_fault+0xdc/0x1740
> [ 91.292934] [<811f93e7>] ? handle_mm_fault+0x417/0x4a0
> [ 91.292934] [<8103e07b>] ? do_page_fault+0x7fb/0xb30
> [ 91.292934] [<810b33e7>] ? up_read+0x37/0x70
> [ 91.292934] [<8103e07b>] ? do_page_fault+0x7fb/0xb30
> [ 91.292934] [<8123c063>] ? do_sys_open+0x3a3/0x3f0
> [ 91.292934] [<8123c063>] ? do_sys_open+0x3a3/0x3f0
> [ 91.292934] [<810b0270>] ? update_rmtp+0xe0/0xe0
> [ 91.292934] [<8150376e>] ? restore_all+0xf/0xf
> [ 91.292934] [<8103d880>] ? vmalloc_sync_all+0x320/0x320
> [ 91.292934] [<81109fca>] ? trace_hardirqs_on_caller+0x28a/0x380
> [ 91.292934] [<81311594>] ? trace_hardirqs_on_thunk+0xc/0x10
> [ 91.292934] [<81503735>] syscall_call+0x7/0xb
>
> Thanks,
> Fengguang
next prev parent reply other threads:[~2012-08-22 2:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20120731121759.GA17822@localhost>
[not found] ` <5017D19B.5080806@redhat.com>
[not found] ` <1343738627.27983.30.camel@gandalf.stny.rr.com>
[not found] ` <5017D4AB.3090107@redhat.com>
[not found] ` <1343740419.27983.33.camel@gandalf.stny.rr.com>
[not found] ` <20120731234336.GA5526@localhost>
[not found] ` <1343778699.27983.70.camel@gandalf.stny.rr.com>
[not found] ` <20120731235705.GW2422@linux.vnet.ibm.com>
[not found] ` <1343779778.27983.73.camel@gandalf.stny.rr.com>
[not found] ` <20120801001811.GX2422@linux.vnet.ibm.com>
2012-08-01 0:43 ` pci_get_subsys: GFP_KERNEL allocations with IRQs disabled Fengguang Wu
2012-08-22 2:50 ` Fengguang Wu [this message]
2012-08-22 7:49 ` Feng Tang
2012-08-22 13:02 ` Fengguang Wu
2012-08-22 18:02 ` Bjorn Helgaas
2012-08-23 5:45 ` Feng Tang
2012-08-23 7:45 ` [PATCH 1/2] PCI: Use local parameter pci_device_id for pci_get_subsys/class() Feng Tang
2012-09-08 1:00 ` Yinghai Lu
2012-09-08 1:32 ` Yinghai Lu
2012-09-08 1:59 ` Greg Kroah-Hartman
2012-09-08 13:42 ` Fengguang Wu
2012-09-08 15:30 ` Yinghai Lu
2012-09-08 15:34 ` Feng Tang
2012-09-08 18:40 ` Yinghai Lu
2012-09-08 21:06 ` Bjorn Helgaas
2012-08-23 7:45 ` [PATCH 2/2] PCI: Remove the obsolete no_pci_devices() check Feng Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120822025008.GA8066@localhost \
--to=fengguang.wu@intel.com \
--cc=avi@redhat.com \
--cc=bhelgaas@google.com \
--cc=feng.tang@intel.com \
--cc=kaneshige.kenji@jp.fujitsu.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=rostedt@goodmis.org \
--cc=srostedt@redhat.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).