linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Feng Tang <feng.tang@intel.com>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: Fengguang Wu <fengguang.wu@intel.com>,
	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
	Steven Rostedt <rostedt@goodmis.org>, Avi Kivity <avi@redhat.com>,
	Steven Rostedt <srostedt@redhat.com>,
	LKML <linux-kernel@vger.kernel.org>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>,
	Yinghai Lu <yinghai@kernel.org>, <linux-pci@vger.kernel.org>,
	akpm@linux-foundation.org, gregkh@linuxfoundation.org
Subject: [PATCH 2/2] PCI: Remove the obsolete no_pci_devices() check
Date: Thu, 23 Aug 2012 15:45:47 +0800	[thread overview]
Message-ID: <20120823154547.40d07cd0@feng-i7> (raw)
In-Reply-To: <CAErSpo7HhdDi4EhbQZ-oZbsbGVvTfZW8MwKn7Tm+6B8jaQxLBg@mail.gmail.com>

>From 9f2f3bbdf65f669e091c72b9648a4a0394ce28f5 Mon Sep 17 00:00:00 2001
From: Feng Tang <feng.tang@intel.com>
Date: Thu, 23 Aug 2012 14:55:48 +0800
Subject: [PATCH 2/2] PCI: Remove the obsolete no_pci_devices() check

In function pci_get_subsys() there is a check:

	/*
	 * pci_find_subsys() can be called on the ide_setup() path,
	 * super-early in boot.  But the down_read() will enable local
	 * interrupts, which can cause some machines to crash.  So here we
	 * detect and flag that situation and bail out early.
	 */
	if (unlikely(no_pci_devices()))
		return NULL;

But there is no ide_setup() now, and no down_read() either, which
makes the check absolete. So remove it.

Signed-off-by: Feng Tang <feng.tang@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 drivers/pci/search.c |    9 ---------
 1 files changed, 0 insertions(+), 9 deletions(-)

diff --git a/drivers/pci/search.c b/drivers/pci/search.c
index 78a08b1..e6e604f 100644
--- a/drivers/pci/search.c
+++ b/drivers/pci/search.c
@@ -247,15 +247,6 @@ struct pci_dev *pci_get_subsys(unsigned int vendor, unsigned int device,
 {
 	struct pci_device_id id;
 
-	/*
-	 * pci_find_subsys() can be called on the ide_setup() path,
-	 * super-early in boot.  But the down_read() will enable local
-	 * interrupts, which can cause some machines to crash.  So here we
-	 * detect and flag that situation and bail out early.
-	 */
-	if (unlikely(no_pci_devices()))
-		return NULL;
-
 	id.vendor = vendor;
 	id.device = device;
 	id.subvendor = ss_vendor;
-- 
1.7.1

      parent reply	other threads:[~2012-08-23  7:45 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20120731121759.GA17822@localhost>
     [not found] ` <5017D19B.5080806@redhat.com>
     [not found]   ` <1343738627.27983.30.camel@gandalf.stny.rr.com>
     [not found]     ` <5017D4AB.3090107@redhat.com>
     [not found]       ` <1343740419.27983.33.camel@gandalf.stny.rr.com>
     [not found]         ` <20120731234336.GA5526@localhost>
     [not found]           ` <1343778699.27983.70.camel@gandalf.stny.rr.com>
     [not found]             ` <20120731235705.GW2422@linux.vnet.ibm.com>
     [not found]               ` <1343779778.27983.73.camel@gandalf.stny.rr.com>
     [not found]                 ` <20120801001811.GX2422@linux.vnet.ibm.com>
2012-08-01  0:43                   ` pci_get_subsys: GFP_KERNEL allocations with IRQs disabled Fengguang Wu
2012-08-22  2:50                     ` Fengguang Wu
2012-08-22  7:49                       ` Feng Tang
2012-08-22 13:02                         ` Fengguang Wu
2012-08-22 18:02                         ` Bjorn Helgaas
2012-08-23  5:45                           ` Feng Tang
2012-08-23  7:45                           ` [PATCH 1/2] PCI: Use local parameter pci_device_id for pci_get_subsys/class() Feng Tang
2012-09-08  1:00                             ` Yinghai Lu
2012-09-08  1:32                               ` Yinghai Lu
2012-09-08  1:59                                 ` Greg Kroah-Hartman
2012-09-08 13:42                                 ` Fengguang Wu
2012-09-08 15:30                                   ` Yinghai Lu
2012-09-08 15:34                                   ` Feng Tang
2012-09-08 18:40                                     ` Yinghai Lu
2012-09-08 21:06                                       ` Bjorn Helgaas
2012-08-23  7:45                           ` Feng Tang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120823154547.40d07cd0@feng-i7 \
    --to=feng.tang@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=avi@redhat.com \
    --cc=bhelgaas@google.com \
    --cc=fengguang.wu@intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kaneshige.kenji@jp.fujitsu.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=rostedt@goodmis.org \
    --cc=srostedt@redhat.com \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).