From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
linux-doc@vger.kernel.org, Joerg Roedel <joro@8bytes.org>,
Randy Dunlap <rdunlap@infradead.org>,
Liviu Dudau <Liviu.Dudau@arm.com>,
linux-kernel@vger.kernel.org,
James Bottomley <jbottomley@parallels.com>,
linux-pci@vger.kernel.org, David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH v3 2/4] DMA-API: Change dma_declare_coherent_memory() CPU address to phys_addr_t
Date: Fri, 9 May 2014 04:50:14 +0200 [thread overview]
Message-ID: <20140509025014.GE21085@kroah.com> (raw)
In-Reply-To: <20140508204900.17877.3108.stgit@bhelgaas-glaptop.roam.corp.google.com>
On Thu, May 08, 2014 at 02:49:00PM -0600, Bjorn Helgaas wrote:
> dma_declare_coherent_memory() takes two addresses for a region of memory: a
> "bus_addr" and a "device_addr". I think the intent is that "bus_addr" is
> the physical address a *CPU* would use to access the region, and
> "device_addr" is the bus address the *device* would use to address the
> region.
>
> Rename "bus_addr" to "phys_addr" and change its type to phys_addr_t.
> Most callers already supply a phys_addr_t for this argument. The others
> supply a 32-bit integer (a constant, unsigned int, or __u32) and need no
> change.
>
> Use "unsigned long", not phys_addr_t, to hold PFNs.
>
> No functional change (this could theoretically fix a truncation in a config
> with 32-bit dma_addr_t and 64-bit phys_addr_t, but I don't think there are
> any such cases involving this code).
>
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
next prev parent reply other threads:[~2014-05-09 2:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-08 20:48 [PATCH v3 0/4] Clean up DMA API docs and dma_addr_t usage Bjorn Helgaas
2014-05-08 20:48 ` [PATCH v3 1/4] DMA-API: Clarify physical/bus address distinction Bjorn Helgaas
2014-05-09 2:49 ` Greg Kroah-Hartman
2014-05-09 6:12 ` Arnd Bergmann
2014-05-09 14:09 ` James Bottomley
2014-05-08 20:49 ` [PATCH v3 2/4] DMA-API: Change dma_declare_coherent_memory() CPU address to phys_addr_t Bjorn Helgaas
2014-05-09 2:50 ` Greg Kroah-Hartman [this message]
2014-05-08 20:49 ` [PATCH v3 3/4] sh/PCI: Pass GAPSPCI_DMA_BASE CPU & bus address to dma_declare_coherent_memory() Bjorn Helgaas
2014-05-26 14:46 ` Geert Uytterhoeven
2014-05-26 23:33 ` Bjorn Helgaas
2014-05-08 20:49 ` [PATCH v3 4/4] iommu/exynos: Remove unnecessary "&" from function pointers Bjorn Helgaas
2014-05-14 10:23 ` [PATCH v3 0/4] Clean up DMA API docs and dma_addr_t usage Joerg Roedel
2014-05-14 15:50 ` Randy Dunlap
2014-05-14 15:56 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140509025014.GE21085@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Liviu.Dudau@arm.com \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=dwmw2@infradead.org \
--cc=jbottomley@parallels.com \
--cc=joro@8bytes.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).