From: Mark D Rustad <mark.d.rustad@intel.com>
To: bhelgaas@google.com
Cc: linux-pci@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
netdev@vger.kernel.org
Subject: [PATCH] pci: Use a bus-global mutex to protect VPD operations
Date: Mon, 18 May 2015 17:00:37 -0700 [thread overview]
Message-ID: <20150519000037.56109.68356.stgit@mdrustad-wks.jf.intel.com> (raw)
Some devices have a problem with concurrent VPD access to different
functions of the same physical device, so move the protecting mutex
from the pci_vpd structure to the pci_bus structure. There are a
number of reports on support sites for a variety of devices from
various vendors getting the "vpd r/w failed" message. This is likely
to at least fix some of them. Thanks to Shannon Nelson for helping
to come up with this approach.
Signed-off-by: Mark Rustad <mark.d.rustad@intel.com>
Acked-by: Shannon Nelson <shannon.nelson@intel.com>
Acked-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
drivers/pci/access.c | 10 ++++------
drivers/pci/probe.c | 1 +
2 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/pci/access.c b/drivers/pci/access.c
index d9b64a175990..6a1c8d6f95f1 100644
--- a/drivers/pci/access.c
+++ b/drivers/pci/access.c
@@ -281,7 +281,6 @@ PCI_USER_WRITE_CONFIG(dword, u32)
struct pci_vpd_pci22 {
struct pci_vpd base;
- struct mutex lock;
u16 flag;
bool busy;
u8 cap;
@@ -340,7 +339,7 @@ static ssize_t pci_vpd_pci22_read(struct pci_dev *dev, loff_t pos, size_t count,
if (pos < 0 || pos > vpd->base.len || end > vpd->base.len)
return -EINVAL;
- if (mutex_lock_killable(&vpd->lock))
+ if (mutex_lock_killable(&dev->bus->vpd_mutex))
return -EINTR;
ret = pci_vpd_pci22_wait(dev);
@@ -376,7 +375,7 @@ static ssize_t pci_vpd_pci22_read(struct pci_dev *dev, loff_t pos, size_t count,
}
}
out:
- mutex_unlock(&vpd->lock);
+ mutex_unlock(&dev->bus->vpd_mutex);
return ret ? ret : count;
}
@@ -392,7 +391,7 @@ static ssize_t pci_vpd_pci22_write(struct pci_dev *dev, loff_t pos, size_t count
if (pos < 0 || (pos & 3) || (count & 3) || end > vpd->base.len)
return -EINVAL;
- if (mutex_lock_killable(&vpd->lock))
+ if (mutex_lock_killable(&dev->bus->vpd_mutex))
return -EINTR;
ret = pci_vpd_pci22_wait(dev);
@@ -424,7 +423,7 @@ static ssize_t pci_vpd_pci22_write(struct pci_dev *dev, loff_t pos, size_t count
pos += sizeof(u32);
}
out:
- mutex_unlock(&vpd->lock);
+ mutex_unlock(&dev->bus->vpd_mutex);
return ret ? ret : count;
}
@@ -453,7 +452,6 @@ int pci_vpd_pci22_init(struct pci_dev *dev)
vpd->base.len = PCI_VPD_PCI22_SIZE;
vpd->base.ops = &pci_vpd_pci22_ops;
- mutex_init(&vpd->lock);
vpd->cap = cap;
vpd->busy = false;
dev->vpd = &vpd->base;
diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c
index 6675a7a1b9fc..40c2a5a751d0 100644
--- a/drivers/pci/probe.c
+++ b/drivers/pci/probe.c
@@ -494,6 +494,7 @@ static struct pci_bus *pci_alloc_bus(struct pci_bus *parent)
INIT_LIST_HEAD(&b->devices);
INIT_LIST_HEAD(&b->slots);
INIT_LIST_HEAD(&b->resources);
+ mutex_init(&b->vpd_mutex);
b->max_bus_speed = PCI_SPEED_UNKNOWN;
b->cur_bus_speed = PCI_SPEED_UNKNOWN;
#ifdef CONFIG_PCI_DOMAINS_GENERIC
diff --git a/include/linux/pci.h b/include/linux/pci.h
index 353db8dc4c6e..f8a51d172255 100644
--- a/include/linux/pci.h
+++ b/include/linux/pci.h
@@ -454,6 +454,7 @@ struct pci_bus {
struct msi_controller *msi; /* MSI controller */
void *sysdata; /* hook for sys-specific extension */
struct proc_dir_entry *procdir; /* directory entry in /proc/bus/pci */
+ struct mutex vpd_mutex; /* bus-wide VPD access mutex */
unsigned char number; /* bus number */
unsigned char primary; /* number of primary bridge */
next reply other threads:[~2015-05-19 0:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-19 0:00 Mark D Rustad [this message]
2015-05-19 17:55 ` [Intel-wired-lan] [PATCH] pci: Use a bus-global mutex to protect VPD operations Alexander Duyck
2015-05-19 18:28 ` Rustad, Mark D
2015-05-19 20:58 ` Alexander Duyck
2015-05-19 21:53 ` Rustad, Mark D
2015-05-19 23:19 ` Alexander Duyck
2015-05-19 23:01 ` Jesse Brandeburg
2015-05-20 0:07 ` Alexander Duyck
2015-05-20 0:34 ` Rustad, Mark D
2015-05-20 1:02 ` Alexander Duyck
2015-05-20 16:00 ` Rustad, Mark D
2015-05-20 21:26 ` Alexander Duyck
2015-05-27 17:27 ` Bjorn Helgaas
2015-05-27 19:11 ` Rustad, Mark D
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150519000037.56109.68356.stgit@mdrustad-wks.jf.intel.com \
--to=mark.d.rustad@intel.com \
--cc=bhelgaas@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=linux-pci@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).