From: Bjorn Helgaas <bhelgaas@google.com>
To: Jesper Nilsson <jesper.nilsson@axis.com>,
Niklas Cassel <niklas.cassel@axis.com>
Cc: linux-pci@vger.kernel.org, linux-arm-kernel@axis.com
Subject: [PATCH v2 5/7] PCI: artpec6: Remove unnecessary artpec6_pcie_link_up()
Date: Wed, 12 Oct 2016 08:29:36 -0500 [thread overview]
Message-ID: <20161012132936.27228.79392.stgit@bhelgaas-glaptop2.roam.corp.google.com> (raw)
In-Reply-To: <20161012132616.27228.4618.stgit@bhelgaas-glaptop2.roam.corp.google.com>
Remove artpec6_pcie_link_up(); the generic dw_pcie_link_up() does the same
thing, so we don't need a device-specific version.
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Acked-by: Jesper Nilsson <jesper.nilsson@axis.com>
---
drivers/pci/host/pcie-artpec6.c | 16 ----------------
1 file changed, 16 deletions(-)
diff --git a/drivers/pci/host/pcie-artpec6.c b/drivers/pci/host/pcie-artpec6.c
index b3829d0..d3e7a40 100644
--- a/drivers/pci/host/pcie-artpec6.c
+++ b/drivers/pci/host/pcie-artpec6.c
@@ -177,23 +177,7 @@ static void artpec6_pcie_host_init(struct pcie_port *pp)
artpec6_pcie_enable_interrupts(pp);
}
-static int artpec6_pcie_link_up(struct pcie_port *pp)
-{
- u32 rc;
-
- /*
- * Get status from Synopsys IP
- * link is debug bit 36, debug register 1 starts at bit 32
- */
- rc = readl(pp->dbi_base + PCIE_PHY_DEBUG_R1) & (0x1 << (36 - 32));
- if (rc)
- return 1;
-
- return 0;
-}
-
static struct pcie_host_ops artpec6_pcie_host_ops = {
- .link_up = artpec6_pcie_link_up,
.host_init = artpec6_pcie_host_init,
};
next prev parent reply other threads:[~2016-10-12 13:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-12 13:28 [PATCH v2 0/7] PCI: artpec: Cleanups Bjorn Helgaas
2016-10-12 13:29 ` [PATCH v2 1/7] PCI: artpec6: Add local struct device pointers Bjorn Helgaas
2016-10-12 13:29 ` [PATCH v2 2/7] PCI: artpec6: Remove unused platform data Bjorn Helgaas
2016-10-12 13:29 ` [PATCH v2 3/7] PCI: artpec6: Add register accessors Bjorn Helgaas
2016-10-12 13:29 ` [PATCH v2 4/7] PCI: artpec6: Use generic DesignWare accessors Bjorn Helgaas
2016-10-12 13:29 ` Bjorn Helgaas [this message]
2016-10-12 13:29 ` [PATCH v2 6/7] PCI: artpec6: Pass device-specific struct to internal functions Bjorn Helgaas
2016-10-12 13:29 ` [PATCH v2 7/7] PCI: artpec6: Add resource name comments Bjorn Helgaas
2016-10-12 16:04 ` [PATCH v2 0/7] PCI: artpec: Cleanups Bjorn Helgaas
2016-10-12 20:40 ` Jesper Nilsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161012132936.27228.79392.stgit@bhelgaas-glaptop2.roam.corp.google.com \
--to=bhelgaas@google.com \
--cc=jesper.nilsson@axis.com \
--cc=linux-arm-kernel@axis.com \
--cc=linux-pci@vger.kernel.org \
--cc=niklas.cassel@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).