From: Bjorn Helgaas <bhelgaas@google.com>
To: Kishon Vijay Abraham I <kishon@ti.com>
Cc: linux-pci@vger.kernel.org, linux-omap@vger.kernel.org
Subject: [PATCH v2 3/7] PCI: dra7xx: Set drvdata at end of probe function
Date: Wed, 12 Oct 2016 08:32:58 -0500 [thread overview]
Message-ID: <20161012133258.27714.51056.stgit@bhelgaas-glaptop2.roam.corp.google.com> (raw)
In-Reply-To: <20161012133112.27714.93244.stgit@bhelgaas-glaptop2.roam.corp.google.com>
Set the drvdata pointer at the end of probe function for consistency with
other drivers. We don't need the drvdata until after the probe completes,
and we don't need it at all if the probe fails. No functional change
intended.
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
---
drivers/pci/host/pci-dra7xx.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/pci/host/pci-dra7xx.c b/drivers/pci/host/pci-dra7xx.c
index 1c24f34..3d184f6 100644
--- a/drivers/pci/host/pci-dra7xx.c
+++ b/drivers/pci/host/pci-dra7xx.c
@@ -418,12 +418,11 @@ static int __init dra7xx_pcie_probe(struct platform_device *pdev)
reg &= ~LTSSM_EN;
dra7xx_pcie_writel(dra7xx, PCIECTRL_DRA7XX_CONF_DEVICE_CMD, reg);
- platform_set_drvdata(pdev, dra7xx);
-
ret = dra7xx_add_pcie_port(dra7xx, pdev);
if (ret < 0)
goto err_gpio;
+ platform_set_drvdata(pdev, dra7xx);
return 0;
err_gpio:
next prev parent reply other threads:[~2016-10-12 13:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-12 13:32 [PATCH v2 0/7] PCI: dra7xx: Cleanups Bjorn Helgaas
2016-10-12 13:32 ` [PATCH v2 1/7] PCI: dra7xx: Add local struct device pointers Bjorn Helgaas
2016-10-12 13:32 ` [PATCH v2 2/7] PCI: dra7xx: Remove redundant struct device pointer from dra7xx_pcie Bjorn Helgaas
2016-10-12 13:32 ` Bjorn Helgaas [this message]
2016-10-12 19:48 ` [PATCH v2 3/7] PCI: dra7xx: Set drvdata at end of probe function Andrew F. Davis
2016-10-12 22:21 ` Bjorn Helgaas
2016-10-13 15:24 ` Andrew F. Davis
2016-10-12 13:33 ` [PATCH v2 4/7] PCI: dra7xx: Use generic DesignWare accessors Bjorn Helgaas
2016-10-12 13:33 ` [PATCH v2 5/7] PCI: dra7xx: Pass device-specific struct to internal functions Bjorn Helgaas
2016-10-12 13:33 ` [PATCH v2 6/7] PCI: dra7xx: Move struct pcie_port setup to probe function Bjorn Helgaas
2016-10-12 19:58 ` Andrew F. Davis
2016-10-12 13:33 ` [PATCH v2 7/7] PCI: dra7xx: Reorder struct dra7xx_pcie Bjorn Helgaas
2016-10-12 16:04 ` [PATCH v2 0/7] PCI: dra7xx: Cleanups Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161012133258.27714.51056.stgit@bhelgaas-glaptop2.roam.corp.google.com \
--to=bhelgaas@google.com \
--cc=kishon@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).