From: Bjorn Helgaas <bhelgaas@google.com>
To: linux-pci@vger.kernel.org,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Cc: Lukas Wunner <lukas@wunner.de>, linux-kernel@vger.kernel.org
Subject: [PATCH v2 9/9] PCI: Expand "VPD access disabled" quirk message
Date: Mon, 21 Nov 2016 15:46:17 -0600 [thread overview]
Message-ID: <20161121214617.21036.65418.stgit@bhelgaas-glaptop.roam.corp.google.com> (raw)
In-Reply-To: <20161121214006.21036.11599.stgit@bhelgaas-glaptop.roam.corp.google.com>
It's not very enlightening to see
pci 0000:07:00.0: [Firmware Bug]: VPD access disabled
in the dmesg log because there's no clue about what the firmware bug is.
Expand the message to explain why we're disabling VPD.
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
---
drivers/pci/quirks.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
index c232729..7329796 100644
--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
@@ -2156,7 +2156,7 @@ static void quirk_blacklist_vpd(struct pci_dev *dev)
{
if (dev->vpd) {
dev->vpd->len = 0;
- dev_warn(&dev->dev, FW_BUG "VPD access disabled\n");
+ dev_warn(&dev->dev, FW_BUG "disabling VPD access (can't determine size of non-standard VPD format)\n");
}
}
next prev parent reply other threads:[~2016-11-21 21:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-21 21:45 [PATCH v2 0/9] PCI: Tidy up messages Bjorn Helgaas
2016-11-21 21:45 ` [PATCH v2 1/9] PCI/PME: Drop unused support for PMEs from Root Complex Event Collectors Bjorn Helgaas
2016-11-21 22:28 ` Rafael J. Wysocki
2016-11-21 22:42 ` Bjorn Helgaas
2016-11-21 22:58 ` Rafael J. Wysocki
2016-11-21 23:00 ` Bjorn Helgaas
2016-11-21 21:45 ` [PATCH v2 2/9] PCI/PME: Log PME IRQ when claiming Root Port Bjorn Helgaas
2016-11-21 22:29 ` Rafael J. Wysocki
2016-11-21 21:45 ` [PATCH v2 3/9] PCI/AER: Remove unused version macros Bjorn Helgaas
2016-11-21 21:45 ` [PATCH v2 4/9] PCI/AER: Log errors with PCI device, not PCIe service device Bjorn Helgaas
2016-11-21 21:45 ` [PATCH v2 5/9] PCI/AER: Log AER IRQ when claiming Root Port Bjorn Helgaas
2016-11-21 21:45 ` [PATCH v2 6/9] PCI: Remove service driver load/unload messages Bjorn Helgaas
2016-11-21 21:46 ` [PATCH v2 7/9] PCI: hotplug: Remove hotplug core message Bjorn Helgaas
2016-11-21 21:46 ` [PATCH v2 8/9] PCI: pciehp: Remove loading message Bjorn Helgaas
2016-11-21 21:46 ` Bjorn Helgaas [this message]
2016-11-23 17:36 ` [PATCH v2 0/9] PCI: Tidy up messages Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161121214617.21036.65418.stgit@bhelgaas-glaptop.roam.corp.google.com \
--to=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=rafael.j.wysocki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).