Linux-PCI Archive on lore.kernel.org
 help / color / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Alan Stern <stern@rowland.harvard.edu>, torvalds@linux-foundation.org
Cc: kernel list <linux-kernel@vger.kernel.org>,
	linux-usb@vger.kernel.org, gregkh@linuxfoundation.org,
	bhelgaas@google.com, linux-pci@vger.kernel.org
Subject: Re: v4.10-rc8 (-rc6) boot regression on Intel desktop, does not boot after cold boots, boots after reboot
Date: Tue, 14 Feb 2017 18:59:56 +0100
Message-ID: <20170214175956.GA3587@amd> (raw)
In-Reply-To: <20170203211854.GA3697@amd>


[-- Attachment #1: Type: text/plain, Size: 2021 bytes --]

Hi!

> > > > Hmm. I moved keyboard between USB ports, and now 4.10-rc6 no longer
> > > > boots. v4.6 works ok. Let me try with keyboard unplugged... no, I
> > > > could not get it to work. I believe v4.9 and some v4.10-rc's worked,
> > > > but I'll have to double check.
> > > 
> > > But all the kernel versions worked when the keyboard was plugged into
> > > its original USB port?
> > 
> > Aha. So it looks difference is probably in "where is keyboard plugged
> > in" but in "reboot" vs. "cold boot". I did not do a cold boot in quite
> > a while :-(.
> > 
> > Booting to grub, then hitting ctrl-alt-del is enough to make it work. Ouch.
> > 
> > It happens with current Linus' tree.
> 
> v4.10-rc6-feb3 : broken
> v4.9 : ok
> (v4.6 : ok)

Hmm. It hangs during PCI fixups, and it hangs in v4.10-rc8, too.   

With debug patch below, I get

...1d.7: PCI fixup... pass 2
...1d.7: PCI fixup... pass 3
...1d.7: PCI fixup... pass 3 done

...followed by hang. So yes, it looks USB related.

(Sometimes it hangs with some kind backtrace involving secondary CPU
startup, unfortunately useful info is off screen at that point).

Any ideas?
								Pavel

diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
index 1800bef..060ad79 100644
--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
@@ -3510,6 +3510,8 @@ void pci_fixup_device(enum pci_fixup_pass pass, struct pci_dev *dev)
 {
 	struct pci_fixup *start, *end;
 
+	dev_info(&dev->dev, "PCI fixup device %p, pass %d\n", dev, pass);
+
 	switch (pass) {
 	case pci_fixup_early:
 		start = __start_pci_fixups_early;
@@ -3558,6 +3560,7 @@ void pci_fixup_device(enum pci_fixup_pass pass, struct pci_dev *dev)
 		return;
 	}
 	pci_do_fixups(dev, start, end);
+	dev_info(&dev->dev, "PCI fixup device %p, pass %d, done\n", dev, pass);
 }
 EXPORT_SYMBOL(pci_fixup_device);
 


-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

  parent reply index

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20170203190414.GA3701@amd>
     [not found] ` <Pine.LNX.4.44L0.1702031415140.1794-100000@iolanthe.rowland.org>
2017-02-03 20:51   ` v4.10-rc6 " Pavel Machek
2017-02-03 21:18     ` Pavel Machek
2017-02-03 21:59       ` Alan Stern
2017-02-03 22:43         ` Pavel Machek
2017-02-04  8:48           ` Pavel Machek
2017-02-04 16:52             ` Pavel Machek
2017-02-12 12:00             ` Pavel Machek
2017-02-14 17:59       ` Pavel Machek [this message]
2017-02-14 19:27         ` v4.10-rc8 (-rc6) " Pavel Machek
2017-02-14 19:54           ` Alan Stern
2017-02-23 16:28           ` Frederic Weisbecker
2017-02-23 18:40             ` Pavel Machek
2017-02-25  3:28               ` Frederic Weisbecker
2017-03-18 14:42               ` Frederic Weisbecker
2017-04-03 15:38               ` Frederic Weisbecker
2017-04-03 18:20                 ` Pavel Machek
2017-04-12 15:08                   ` Frederic Weisbecker
2017-04-15 21:34                     ` Pavel Machek
2017-04-20 14:52                       ` Frederic Weisbecker
     [not found]         ` <CA+55aFyYAztA+Onquy9ODeC9_YBL_fXAd-RgeUVUhpsjK81ZVQ@mail.gmail.com>
     [not found]           ` <CA+55aFxU1D0hAPJuhkKaFBByi=8vpw7dJUX=FfpoqnZLWsvxig@mail.gmail.com>
     [not found]             ` <CA+55aFwt6pbt2STzRh1yCdoo7AnCLFqnPkkrYk4_BGFuvT2VCw@mail.gmail.com>
     [not found]               ` <CA+55aFzMiXXw9gqNCMCSc+O5HfcqWHXfqbdtbvcOmAHM9_wNig@mail.gmail.com>
     [not found]                 ` <CA+55aFxuXgsCyMgrRDHdM6BQaej68QoU8TwdM=3LYu9LMBf4fQ@mail.gmail.com>
2017-02-15 17:23                   ` Pavel Machek
2017-02-15 23:20                     ` Pavel Machek
2017-02-15 23:34                       ` Linus Torvalds
2017-02-16 11:11                         ` Pavel Machek
2017-02-16 17:25                           ` Pavel Machek
2017-02-16 18:13                             ` Frederic Weisbecker
2017-02-16 18:20                               ` Linus Torvalds
2017-02-16 18:34                                 ` Frederic Weisbecker
2017-02-16 19:34                                   ` Thomas Gleixner
2017-02-16 20:06                                     ` Pavel Machek
2017-02-16 20:21                                       ` Linus Torvalds
2017-02-16 20:48                                         ` Pavel Machek
2017-02-18  8:55                                         ` Pavel Machek
2017-02-17  1:11                                       ` Greg Kroah-Hartman
2017-02-17 14:04                                     ` Frederic Weisbecker
2017-02-17 16:37                                       ` Thomas Gleixner
2017-02-17 17:05                                         ` Pavel Machek
2017-02-17 18:43                                           ` Frederic Weisbecker
2017-02-16 19:06                             ` Pavel Machek
2017-02-17 14:40                               ` Frederic Weisbecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170214175956.GA3587@amd \
    --to=pavel@ucw.cz \
    --cc=bhelgaas@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=stern@rowland.harvard.edu \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-PCI Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-pci/0 linux-pci/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-pci linux-pci/ https://lore.kernel.org/linux-pci \
		linux-pci@vger.kernel.org
	public-inbox-index linux-pci

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-pci


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git