From: Bjorn Helgaas <helgaas@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org,
Andrey Smirnov <andrew.smirnov@gmail.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Fabio Estevam <fabio.estevam@nxp.com>,
Bjorn Helgaas <bhelgaas@google.com>,
yurovsky@gmail.com, Lee Jones <lee.jones@linaro.org>,
linux-arm-kernel@lists.infradead.org,
Lucas Stach <l.stach@pengutronix.de>
Subject: Re: [PATCH v4 3/3] PCI: imx6: Add code to support i.MX7D
Date: Wed, 15 Feb 2017 15:57:51 -0600 [thread overview]
Message-ID: <20170215215751.GD6981@bhelgaas-glaptop.roam.corp.google.com> (raw)
In-Reply-To: <20170215212624.btdhfn4xvuppv6hq@rob-hp-laptop>
On Wed, Feb 15, 2017 at 03:26:24PM -0600, Rob Herring wrote:
> On Wed, Feb 15, 2017 at 11:38:50AM -0600, Bjorn Helgaas wrote:
> > On Wed, Feb 15, 2017 at 11:17:00AM -0600, Rob Herring wrote:
> > > On Tue, Feb 07, 2017 at 07:50:27AM -0800, Andrey Smirnov wrote:
> > > > Add various bits of code needed to support i.MX7D variant of the IP.
>
> > >
> > > [...]
> > >
> > > > @@ -251,6 +261,10 @@ static void imx6_pcie_assert_core_reset(struct imx6_pcie *imx6_pcie)
> > > > u32 val, gpr1, gpr12;
> > > >
> > > > switch (imx6_pcie->variant) {
> > > > + case IMX7D:
> > > > + reset_control_assert(imx6_pcie->pciephy_reset);
> > > > + reset_control_assert(imx6_pcie->apps_reset);
> > > > + break;
> > > > case IMX6SX:
> > > > regmap_update_bits(imx6_pcie->iomuxc_gpr, IOMUXC_GPR12,
> > > > IMX6SX_GPR12_PCIE_TEST_POWERDOWN,
> > >
> > > So the difference with i.MX7D is not really that it has a reset or not,
> > > but some platforms use a reset driver and some do not. The latter should
> > > be fixed.
> >
> > I have this patch queued for v4.11. Are these things that should be
> > fixed first? If so, I can drop this.
>
> Well, depends if you trust things will get fixed later and if the PHY
> in fact should be separate as that affects the binding. It would affect
> how the driver changes are done as instead of "if (IMX7D) ...", you'd
> have "if (imx6_pcie->apps_reset) ..." for example. That part depends on
> how much churn you want there.
I dropped it for now, not that I don't trust it will get fixed, but it
sounds like not completely trivial changes and will affect the binding
as well, so the intermediate state sounds a little messy.
Bjorn
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2017-02-15 21:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-07 15:50 [PATCH v4 0/3] i.MX7 PCI support Andrey Smirnov
2017-02-07 15:50 ` [PATCH v4 1/3] PCI: imx6: Fix a typo in error message Andrey Smirnov
2017-02-07 15:50 ` [PATCH v4 2/3] PCI: imx6: Allow probe deferal by reset GPIO Andrey Smirnov
2017-02-08 0:12 ` kbuild test robot
2017-02-07 15:50 ` [PATCH v4 3/3] PCI: imx6: Add code to support i.MX7D Andrey Smirnov
2017-02-07 16:04 ` Lucas Stach
2017-02-08 12:21 ` Lee Jones
2017-02-15 17:17 ` Rob Herring
2017-02-15 17:38 ` Bjorn Helgaas
2017-02-15 21:26 ` Rob Herring
2017-02-15 21:57 ` Bjorn Helgaas [this message]
2017-02-16 9:18 ` Lucas Stach
2017-02-16 6:07 ` Andrey Smirnov
2017-02-16 9:12 ` Lucas Stach
2017-02-21 16:38 ` Rob Herring
2017-02-21 16:44 ` Lucas Stach
2017-02-10 21:40 ` [PATCH v4 0/3] i.MX7 PCI support Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170215215751.GD6981@bhelgaas-glaptop.roam.corp.google.com \
--to=helgaas@kernel.org \
--cc=andrew.smirnov@gmail.com \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=l.stach@pengutronix.de \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh@kernel.org \
--cc=yurovsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).