From: Bjorn Helgaas <helgaas@kernel.org>
To: Yadi Hu <yadi.hu@windriver.com>
Cc: lftan@altera.com, linux-pci@vger.kernel.org, rfi@lists.rocketboards.org
Subject: Re: [PATCH] PCI: altera: Fix TLP completion status
Date: Fri, 17 Feb 2017 14:26:02 -0600 [thread overview]
Message-ID: <20170217202602.GE17762@bhelgaas-glaptop.roam.corp.google.com> (raw)
In-Reply-To: <1487291230-21495-2-git-send-email-yadi.hu@windriver.com>
On Fri, Feb 17, 2017 at 08:27:10AM +0800, Yadi Hu wrote:
> From: "Hu Yadi" <yadi.hu@windriver.com>
>
> the driver does not use exactly 'Completion Status' value in TLP,
> these bits should be b15:13 not b14:12.
>
> Signed-off-by: Hu Yadi<yadi.hu@windriver.com>
Applied with Ley Foon's ack to pci/host-altera for v4.11, thanks.
BTW, the patch was apparently built against an old kernel (pre-v4.9), so it
didn't apply directly. But I applied it by hand.
> ---
> drivers/pci/host/pcie-altera.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/host/pcie-altera.c b/drivers/pci/host/pcie-altera.c
> index dbac6fb..650862e 100644
> --- a/drivers/pci/host/pcie-altera.c
> +++ b/drivers/pci/host/pcie-altera.c
> @@ -56,7 +56,7 @@
> #define TLP_CFG_DW2(bus, devfn, offset) \
> (((bus) << 24) | ((devfn) << 16) | (offset))
> #define TLP_REQ_ID(bus, devfn) (((bus) << 8) | (devfn))
> -#define TLP_COMP_STATUS(s) (((s) >> 12) & 7)
> +#define TLP_COMP_STATUS(s) (((s) >> 13) & 7)
> #define TLP_HDR_SIZE 3
> #define TLP_LOOP 500
> #define RP_DEVFN 0
> --
> 2.9.3
>
prev parent reply other threads:[~2017-02-17 20:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-17 0:27 PCI: altera: Fix TLP completion status Yadi Hu
2017-02-17 0:27 ` [PATCH] " Yadi Hu
2017-02-17 1:32 ` Ley Foon Tan
2017-02-17 20:26 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170217202602.GE17762@bhelgaas-glaptop.roam.corp.google.com \
--to=helgaas@kernel.org \
--cc=lftan@altera.com \
--cc=linux-pci@vger.kernel.org \
--cc=rfi@lists.rocketboards.org \
--cc=yadi.hu@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).