From: Thierry Reding <thierry.reding@gmail.com>
To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: Manikanta Maddireddy <mmaddireddy@nvidia.com>,
cyndis@kapsi.fi, bhelgaas@google.com, jonathanh@nvidia.com,
robh+dt@kernel.org, frowand.list@gmail.com, rjw@rjwysocki.net,
tglx@linutronix.de, vidyas@nvidia.com, kthota@nvidia.com,
linux-tegra@vger.kernel.org, devicetree@vger.kernel.org,
linux-pci@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH V4 3/7] PCI: tegra: Remove PCI_REASSIGN_ALL_BUS flag for Tegra PCIe
Date: Wed, 20 Dec 2017 20:30:11 +0100 [thread overview]
Message-ID: <20171220193011.GA31757@ulmo> (raw)
In-Reply-To: <20171215173643.GA1050@red-moon>
[-- Attachment #1: Type: text/plain, Size: 1553 bytes --]
On Fri, Dec 15, 2017 at 05:36:43PM +0000, Lorenzo Pieralisi wrote:
> On Fri, Dec 08, 2017 at 02:28:09PM +0530, Manikanta Maddireddy wrote:
> > Primary, secondary and subordinate default bus numbers are 0 in Tegra and
> > it is expecting SW to program these numbers in configration space.
> >
> > pci_scan_bridge_extend() function programs these numbers in configuration
> > space if secondary & subordinate bus numbers are 0 or PCI_REASSIGN_ALL_BUS
> > flag is set. Since secondary & subordinate default bus numbers are 0,
> > PCI_REASSIGN_ALL_BUS flag can be removed for Tegra PCIe.
> >
> > Signed-off-by: Manikanta Maddireddy <mmaddireddy@nvidia.com>
> > ---
> > V3:
> > * new patch in V3
> > V4:
> > * no change in this patch
> >
> > drivers/pci/host/pci-tegra.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/pci/host/pci-tegra.c b/drivers/pci/host/pci-tegra.c
> > index a549c5899e26..0d91f1a3a6b4 100644
> > --- a/drivers/pci/host/pci-tegra.c
> > +++ b/drivers/pci/host/pci-tegra.c
> > @@ -2604,7 +2604,6 @@ static int tegra_pcie_probe(struct platform_device *pdev)
> >
> > tegra_pcie_enable_ports(pcie);
> >
> > - pci_add_flags(PCI_REASSIGN_ALL_BUS);
>
> This looks obviously OK to me but I need Thierry's ACK to queue it.
Just as an additional note: I think the real reason why this is okay to
do is because we reset the PCI host controller in the kernel driver, so
any bus assignments done by the firmware are reset as well.
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-12-20 19:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-08 8:58 [PATCH V4 0/7] Add loadable kernel module and power management support Manikanta Maddireddy
2017-12-08 8:58 ` [PATCH V4 1/7] of: Export of_pci_range_to_resource() Manikanta Maddireddy
2017-12-08 8:58 ` [PATCH V4 2/7] PCI: tegra: Use bus->sysdata to store and get host private data Manikanta Maddireddy
2017-12-12 17:34 ` Bjorn Helgaas
2017-12-14 14:05 ` Thierry Reding
2017-12-08 8:58 ` [PATCH V4 3/7] PCI: tegra: Remove PCI_REASSIGN_ALL_BUS flag for Tegra PCIe Manikanta Maddireddy
2017-12-15 17:36 ` Lorenzo Pieralisi
2017-12-20 19:30 ` Thierry Reding [this message]
2017-12-21 10:46 ` Lorenzo Pieralisi
2018-01-03 15:51 ` Lorenzo Pieralisi
2018-01-03 16:24 ` Manikanta Maddireddy
2017-12-08 8:58 ` [PATCH V4 4/7] PCI: tegra: Free resources on probe failure Manikanta Maddireddy
2017-12-08 8:58 ` [PATCH V4 5/7] PCI: tegra: Add loadable kernel module support Manikanta Maddireddy
2017-12-08 8:58 ` [PATCH V4 6/7] PCI: tegra: Broadcast PME_Turn_Off message before link goes to L2 Manikanta Maddireddy
2017-12-08 8:58 ` [PATCH V4 7/7] PCI: tegra: Add power management support Manikanta Maddireddy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171220193011.GA31757@ulmo \
--to=thierry.reding@gmail.com \
--cc=bhelgaas@google.com \
--cc=cyndis@kapsi.fi \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=kthota@nvidia.com \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mmaddireddy@nvidia.com \
--cc=rjw@rjwysocki.net \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
--cc=vidyas@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).