From: Keith Busch <keith.busch@intel.com>
To: linux-pci@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>
Cc: Maik Broemme <mbroemme@libmpq.org>,
Pawandeep Oza <poza@codeaurora.org>,
Sinan Kaya <okaya@codeaurora.org>,
Keith Busch <keith.busch@intel.com>
Subject: [PATCHv2 6/6] PCI/DPC: Enable ERR_COR
Date: Tue, 16 Jan 2018 22:22:06 -0700 [thread overview]
Message-ID: <20180117052206.7703-7-keith.busch@intel.com> (raw)
In-Reply-To: <20180117052206.7703-1-keith.busch@intel.com>
A DPC port may be configured to send ERR_COR message when the
triggered. This patch enables this feature so additional notification
of the event is possible.
Signed-off-by: Keith Busch <keith.busch@intel.com>
---
drivers/pci/pcie/pcie-dpc.c | 5 ++++-
include/uapi/linux/pci_regs.h | 1 +
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/pci/pcie/pcie-dpc.c b/drivers/pci/pcie/pcie-dpc.c
index 5dfdb4935bac..b7b327367588 100644
--- a/drivers/pci/pcie/pcie-dpc.c
+++ b/drivers/pci/pcie/pcie-dpc.c
@@ -347,7 +347,10 @@ static int dpc_probe(struct pcie_device *dev)
dpc->rp = (cap & PCI_EXP_DPC_CAP_RP_EXT);
- ctl = (ctl & 0xfff4) | PCI_EXP_DPC_CTL_EN_NONFATAL | PCI_EXP_DPC_CTL_INT_EN;
+ ctl = (ctl & 0xfff4) |
+ PCI_EXP_DPC_CTL_EN_NONFATAL |
+ PCI_EXP_DPC_CTL_INT_EN |
+ PCI_EXP_DPC_CTL_ERR_COR;
pci_write_config_word(pdev, dpc->cap_pos + PCI_EXP_DPC_CTL, ctl);
dev_info(device, "DPC error containment capabilities: Int Msg #%d, RPExt%c PoisonedTLP%c SwTrigger%c RP PIO Log %d, DL_ActiveErr%c\n",
diff --git a/include/uapi/linux/pci_regs.h b/include/uapi/linux/pci_regs.h
index 295a5ebdf9e4..0bee9a99dae1 100644
--- a/include/uapi/linux/pci_regs.h
+++ b/include/uapi/linux/pci_regs.h
@@ -976,6 +976,7 @@
#define PCI_EXP_DPC_CTL 6 /* DPC control */
#define PCI_EXP_DPC_CTL_EN_NONFATAL 0x02 /* Enable trigger on ERR_NONFATAL message */
#define PCI_EXP_DPC_CTL_INT_EN 0x08 /* DPC Interrupt Enable */
+#define PCI_EXP_DPC_CTL_ERR_COR 0x10 /* DPC ERR_COR Enable */
#define PCI_EXP_DPC_STATUS 8 /* DPC Status */
#define PCI_EXP_DPC_STATUS_TRIGGER 0x01 /* Trigger Status */
--
2.13.6
prev parent reply other threads:[~2018-01-17 5:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-17 5:22 [PATCHv2 0/6] PCI/DPC updates Keith Busch
2018-01-17 5:22 ` [PATCHv2 1/6] PCI/AER: Return correct value when AER is not supported Keith Busch
2018-01-17 5:22 ` [PATCHv2 2/6] PCI/AER: API for obtaining AER information Keith Busch
2018-01-17 5:22 ` [PATCHv2 3/6] PCI/DPC: Enable DPC in conjuction with AER Keith Busch
2018-01-17 5:22 ` [PATCHv2 4/6] PCI/DPC: Print AER status in DPC event handling Keith Busch
2018-01-25 19:55 ` Bjorn Helgaas
2018-01-25 21:15 ` Keith Busch
2018-01-25 21:19 ` Keith Busch
2018-01-17 5:22 ` [PATCHv2 5/6] PCI/DPC: Fix interrupt message number print Keith Busch
2018-01-17 5:22 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180117052206.7703-7-keith.busch@intel.com \
--to=keith.busch@intel.com \
--cc=bhelgaas@google.com \
--cc=linux-pci@vger.kernel.org \
--cc=mbroemme@libmpq.org \
--cc=okaya@codeaurora.org \
--cc=poza@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).