From: Niklas Cassel <niklas.cassel@axis.com>
To: kishon@ti.com, Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Bjorn Helgaas <bhelgaas@google.com>, Sekhar Nori <nsekhar@ti.com>,
Cyrille Pitchen <cyrille.pitchen@free-electrons.com>,
Niklas Cassel <niklass@axis.com>,
Shawn Lin <shawn.lin@rock-chips.com>,
John Keeping <john@metanate.com>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 1/3] PCI: endpoint: Handle 64-bit BARs properly
Date: Thu, 8 Feb 2018 13:33:44 +0100 [thread overview]
Message-ID: <20180208123346.20784-2-niklas.cassel@axis.com> (raw)
In-Reply-To: <20180208123346.20784-1-niklas.cassel@axis.com>
A 64-bit BAR uses the succeeding BAR for the upper bits, therefore
we cannot call pci_epc_set_bar() on a BAR that follows a 64-bit BAR.
If pci_epc_set_bar() is called with flag PCI_BASE_ADDRESS_MEM_TYPE_64,
it has to be up to the controller driver to write both BAR[x] and BAR[x+1]
(and BAR_mask[x] and BAR_mask[x+1]).
Signed-off-by: Niklas Cassel <niklas.cassel@axis.com>
---
drivers/pci/endpoint/functions/pci-epf-test.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/pci/endpoint/functions/pci-epf-test.c b/drivers/pci/endpoint/functions/pci-epf-test.c
index 800da09d9005..eef85820f59e 100644
--- a/drivers/pci/endpoint/functions/pci-epf-test.c
+++ b/drivers/pci/endpoint/functions/pci-epf-test.c
@@ -382,6 +382,8 @@ static int pci_epf_test_set_bar(struct pci_epf *epf)
if (bar == test_reg_bar)
return ret;
}
+ if (flags & PCI_BASE_ADDRESS_MEM_TYPE_64)
+ bar++;
}
return 0;
--
2.14.2
next prev parent reply other threads:[~2018-02-08 12:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-08 12:33 [PATCH v2 0/3] PCI endpoint 64-bit BAR fixes Niklas Cassel
2018-02-08 12:33 ` Niklas Cassel [this message]
2018-02-08 12:47 ` [PATCH v2 1/3] PCI: endpoint: Handle 64-bit BARs properly Kishon Vijay Abraham I
2018-02-08 15:18 ` Niklas Cassel
2018-02-08 21:57 ` Bjorn Helgaas
2018-02-09 12:44 ` Kishon Vijay Abraham I
2018-02-13 10:28 ` Lorenzo Pieralisi
2018-02-08 12:33 ` [PATCH v2 2/3] misc: pci_endpoint_test: " Niklas Cassel
2018-02-26 17:26 ` Lorenzo Pieralisi
2018-02-26 18:09 ` Bjorn Helgaas
2018-02-08 12:33 ` [PATCH v2 3/3] PCI: designware-ep: Return an error when requesting a too large BAR size Niklas Cassel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180208123346.20784-2-niklas.cassel@axis.com \
--to=niklas.cassel@axis.com \
--cc=bhelgaas@google.com \
--cc=cyrille.pitchen@free-electrons.com \
--cc=john@metanate.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=niklass@axis.com \
--cc=nsekhar@ti.com \
--cc=shawn.lin@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).