From: Bjorn Helgaas <helgaas@kernel.org>
To: Matt Turner <mattst88@gmail.com>
Cc: Yinghai Lu <yinghai@kernel.org>,
linux-pci@vger.kernel.org,
linux-alpha <linux-alpha@vger.kernel.org>,
Richard Henderson <rth@twiddle.net>,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
Jay Estabrook <jay.estabrook@gmail.com>,
Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: Some Alphas broken by f75b99d5a77d (PCI: Enforce bus address limits in resource allocation)
Date: Mon, 16 Apr 2018 16:50:44 -0500 [thread overview]
Message-ID: <20180416215044.GE28657@bhelgaas-glaptop.roam.corp.google.com> (raw)
In-Reply-To: <CAEdQ38GUhL0R4c7ZjEZv89TmqQ0cwhnvBawxuXonSb9On=+B6A@mail.gmail.com>
Hi Matt,
First of all, sorry about breaking Nautilus, and thanks very much for
tracking it down to this commit.
On Mon, Apr 16, 2018 at 07:33:57AM -0700, Matt Turner wrote:
> Commit f75b99d5a77d63f20e07bd276d5a427808ac8ef6 (PCI: Enforce bus
> address limits in resource allocation) broke Alpha systems using
> CONFIG_ALPHA_NAUTILUS. Alpha is 64-bit, but Nautilus systems use a
> 32-bit AMD 751/761 chipset. arch/alpha/kernel/sys_nautilus.c maps PCI
> into the upper addresses just below 4GB.
>
> I can get a working kernel by ifdef'ing out the code in
> drivers/pci/bus.c:pci_bus_alloc_resource. We can't tie
> PCI_BUS_ADDR_T_64BIT to ALPHA_NAUTILUS without breaking generic
> kernels.
>
> How can we get Nautilus working again?
Can you collect a complete dmesg log, ideally both before and after
f75b99d5a77d? I assume the problem is that after f75b99d5a77d? we
erroneously assign space for something above 4GB. But if we know the
correct host bridge apertures, we shouldn't assign space outside them,
regardless of the PCI bus address size.
Coincidentally, Christoph is replacing CONFIG_PCI_BUS_ADDR_T_64BIT
with CONFIG_ARCH_DMA_ADDR_T_64BIT, but I think that change is a no-op
with respect to the problem you're seeing.
[1] https://lkml.kernel.org/r/20180415145947.1248-10-hch@lst.de
next prev parent reply other threads:[~2018-04-16 21:50 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-16 14:33 Some Alphas broken by f75b99d5a77d (PCI: Enforce bus address limits in resource allocation) Matt Turner
2018-04-16 21:50 ` Bjorn Helgaas [this message]
2018-04-17 4:43 ` Matt Turner
2018-04-17 19:43 ` Bjorn Helgaas
2018-04-18 20:48 ` Ivan Kokshaysky
2018-04-20 17:03 ` Bjorn Helgaas
2018-04-22 20:07 ` Matt Turner
2018-04-23 17:34 ` Ivan Kokshaysky
2018-05-02 20:33 ` Bjorn Helgaas
2018-05-02 21:10 ` Matt Turner
2018-05-07 0:46 ` Matt Turner
2019-10-18 5:57 ` Matt Turner
2020-02-22 16:55 ` Bjorn Helgaas
2020-02-28 23:51 ` Matt Turner
2020-03-01 14:30 ` Ivan Kokshaysky
2020-03-02 22:47 ` Bjorn Helgaas
2020-03-08 15:30 ` Ivan Kokshaysky
2020-03-08 19:41 ` Matt Turner
2020-03-12 4:28 ` Matt Turner
2020-03-12 20:19 ` Bjorn Helgaas
2020-03-12 20:49 ` Ivan Kokshaysky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180416215044.GE28657@bhelgaas-glaptop.roam.corp.google.com \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=ink@jurassic.park.msu.ru \
--cc=jay.estabrook@gmail.com \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mattst88@gmail.com \
--cc=rth@twiddle.net \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).