From: Bjorn Helgaas <helgaas@kernel.org>
To: Myron Stowe <myron.stowe@redhat.com>
Cc: bhelgaas@google.com, linux-pci@vger.kernel.org,
keith.busch@intel.com, jdmason@kudzu.us, okaya@kernel.org
Subject: Re: [PATCH 0/2] Augment device matching its upstream Root Port's MPS logic
Date: Tue, 14 Aug 2018 09:18:57 -0500 [thread overview]
Message-ID: <20180814141857.GO113140@bhelgaas-glaptop.roam.corp.google.com> (raw)
In-Reply-To: <20180813181931.105655.22182.stgit@tak.stowe>
On Mon, Aug 13, 2018 at 12:19:31PM -0600, Myron Stowe wrote:
> In commit 27d868b5e6cf ("PCI: Set MPS to match upstream bridge") Keith made
> sure every device's MPS setting matched its upstream bridge, making it more
> likely that a hot-added devices would work in a system with an optimized MPS
> configuration.
>
> This series augments Keith's approach to include tuning down a Root Port's
> MPS setting in the case where a hot-added device is not capable of matching
> it (see: [1]).
>
> Testing by Dongdong exposed a bug with the logic including Virtual Functions
> (VFs). VFs should not be included so a pre-cursor patch, 1/2, was added to
> cover such.
>
> [1] https://bugzilla.kernel.org/show_bug.cgi?id=200527
>
> Myron Stowe (2):
> PCI: Skip MPS logic for Virtual Functions (VFs)
> PCI: Match Root Port's MPS to endpoint's MPSS as necessary
>
>
> drivers/pci/probe.c | 16 ++++++++++++++--
> 1 file changed, 14 insertions(+), 2 deletions(-)
Applied to pci/enumeration for v4.19, thanks!
prev parent reply other threads:[~2018-08-14 17:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-13 18:19 [PATCH 0/2] Augment device matching its upstream Root Port's MPS logic Myron Stowe
2018-08-13 18:19 ` [PATCH 1/2] PCI: Skip MPS logic for Virtual Functions (VFs) Myron Stowe
2018-08-13 18:19 ` [PATCH 2/2] PCI: Match Root Port's MPS to endpoint's MPSS as necessary Myron Stowe
2018-08-14 14:18 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180814141857.GO113140@bhelgaas-glaptop.roam.corp.google.com \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=jdmason@kudzu.us \
--cc=keith.busch@intel.com \
--cc=linux-pci@vger.kernel.org \
--cc=myron.stowe@redhat.com \
--cc=okaya@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).