From: Bjorn Helgaas <helgaas@kernel.org>
To: "Derrick, Jonathan" <jonathan.derrick@intel.com>
Cc: "willy@infradead.org" <willy@infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"okaya@kernel.org" <okaya@kernel.org>,
"liudongdong3@huawei.com" <liudongdong3@huawei.com>,
"poza@codeaurora.org" <poza@codeaurora.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"Busch, Keith" <keith.busch@intel.com>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>
Subject: Re: [PATCH 1/2] PCI/DPC: Add 'nodpc' parameter
Date: Thu, 16 Aug 2018 15:31:11 -0500 [thread overview]
Message-ID: <20180816203111.GB10316@bhelgaas-glaptop.roam.corp.google.com> (raw)
In-Reply-To: <1534434641.17819.27.camel@intel.com>
On Thu, Aug 16, 2018 at 03:50:47PM +0000, Derrick, Jonathan wrote:
> On Thu, 2018-08-16 at 08:49 -0700, Matthew Wilcox wrote:
> > On Wed, Aug 15, 2018 at 03:26:39PM -0600, Jon Derrick wrote:
> > > Some users may want to disable downstream port containment (DPC),
> > > so
> > > give them this option
> >
> > Is it possible they might only want to disable DPC on a subset of the
> > hierarchy rather than globally?
>
> Absolutely. I was hoping Logan's pci dev_str would land because I have
> a few others I want to convert to that api for granular tuning
What's the use case here? I acknowledge there are cases where we need
them, but I'm not a fan of kernel parameters in general because
they're a real hassle for users.
Is there something wrong with DPC? Is there some way we can make it
smarter so it does the right thing automatically?
I'm more OK with a blanket "nodpc" switch intended for debugging.
If we add the complexity of subsets of the hierarchy it starts
sounding like an administrative thing that makes me more hesitant.
Could this be done via a sysfs switch instead? That potentially could
work for hot-added things where a kernel parameter doesn't work so
well.
Please squash the doc patch and the code change so it's easier to keep
them together.
Bjorn
next prev parent reply other threads:[~2018-08-16 23:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-15 21:26 [PATCH 1/2] PCI/DPC: Add 'nodpc' parameter Jon Derrick
2018-08-15 21:26 ` [PATCH 2/2] Documentation: Document pci=nodpc Jon Derrick
2018-08-15 23:03 ` [PATCH 1/2] PCI/DPC: Add 'nodpc' parameter Keith Busch
2018-08-16 9:27 ` poza
2018-08-16 15:45 ` Derrick, Jonathan
2018-08-16 15:49 ` Matthew Wilcox
2018-08-16 15:50 ` Derrick, Jonathan
2018-08-16 20:31 ` Bjorn Helgaas [this message]
2018-08-16 20:50 ` Derrick, Jonathan
2018-08-16 21:19 ` Keith Busch
2018-08-16 21:28 ` Derrick, Jonathan
2018-08-17 14:25 ` Bjorn Helgaas
2018-08-17 14:45 ` Derrick, Jonathan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180816203111.GB10316@bhelgaas-glaptop.roam.corp.google.com \
--to=helgaas@kernel.org \
--cc=jonathan.derrick@intel.com \
--cc=keith.busch@intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=liudongdong3@huawei.com \
--cc=okaya@kernel.org \
--cc=poza@codeaurora.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).