From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,TVD_PH_BODY_ACCOUNTS_PRE, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 982F0C433F4 for ; Tue, 18 Sep 2018 14:36:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 52831214C2 for ; Tue, 18 Sep 2018 14:36:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 52831214C2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-pci-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729689AbeIRUIw (ORCPT ); Tue, 18 Sep 2018 16:08:52 -0400 Received: from foss.arm.com ([217.140.101.70]:46038 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727348AbeIRUIw (ORCPT ); Tue, 18 Sep 2018 16:08:52 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3FFD27A9; Tue, 18 Sep 2018 07:35:59 -0700 (PDT) Received: from e107981-ln.cambridge.arm.com (e107981-ln.emea.arm.com [10.4.13.117]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4F37B3F5BD; Tue, 18 Sep 2018 07:35:57 -0700 (PDT) Date: Tue, 18 Sep 2018 15:35:54 +0100 From: Lorenzo Pieralisi To: kbuild test robot Cc: Hanjie Lin , kbuild-all@01.org, Bjorn Helgaas , Yue Wang , Kevin Hilman , Rob Herring , linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org Subject: Re: [PATCH] PCI: meson: fix ptr_ret.cocci warnings Message-ID: <20180918143554.GC32243@e107981-ln.cambridge.arm.com> References: <1534227522-186798-3-git-send-email-hanjie.lin@amlogic.com> <20180814114518.GA82641@lkp-ib04> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180814114518.GA82641@lkp-ib04> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Message-ID: <20180918143554.n666xC_XgBOJh_nijuvm6myN0u60GnnP3B_VMi48DV4@z> On Tue, Aug 14, 2018 at 07:45:18PM +0800, kbuild test robot wrote: > From: kbuild test robot > > drivers/pci/controller/dwc/pci-meson.c:121:1-3: WARNING: PTR_ERR_OR_ZERO can be used > > > Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR > > Generated by: scripts/coccinelle/api/ptr_ret.cocci > > Fixes: b43bb00f7533 ("PCI: meson: add the Amlogic Meson PCIe controller driver") > CC: Yue Wang > Signed-off-by: kbuild test robot > --- > > pci-meson.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) I have dropped this patch from the PCI patch queue since it was taken into account in updated patches versions, thanks for sending it. Thanks, Lorenzo > --- a/drivers/pci/controller/dwc/pci-meson.c > +++ b/drivers/pci/controller/dwc/pci-meson.c > @@ -118,10 +118,7 @@ static int meson_pcie_get_mem(struct pla > return -ENODEV; > > mp->mem_res.cfg_base = devm_ioremap_resource(dev, res); > - if (IS_ERR(mp->mem_res.cfg_base)) > - return PTR_ERR(mp->mem_res.cfg_base); > - > - return 0; > + return PTR_ERR_OR_ZERO(mp->mem_res.cfg_base); > } > > static int meson_pcie_init_clk(struct meson_pcie *mp)