From: Jacob Pan <jacob.jun.pan@linux.intel.com>
To: Jean-Philippe Brucker <jean-philippe.brucker@arm.com>
Cc: "iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
"joro@8bytes.org" <joro@8bytes.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"jcrouse@codeaurora.org" <jcrouse@codeaurora.org>,
"alex.williamson@redhat.com" <alex.williamson@redhat.com>,
"Jonathan.Cameron@huawei.com" <Jonathan.Cameron@huawei.com>,
"christian.koenig@amd.com" <christian.koenig@amd.com>,
"eric.auger@redhat.com" <eric.auger@redhat.com>,
"kevin.tian@intel.com" <kevin.tian@intel.com>,
"yi.l.liu@intel.com" <yi.l.liu@intel.com>,
Andrew Murray <Andrew.Murray@arm.com>,
Will Deacon <Will.Deacon@arm.com>,
Robin Murphy <Robin.Murphy@arm.com>,
"ashok.raj@intel.com" <ashok.raj@intel.com>,
"baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>,
"xuzaibo@huawei.com" <xuzaibo@huawei.com>,
"liguozhu@hisilicon.com" <liguozhu@hisilicon.com>,
"okaya@codeaurora.org" <okaya@codeaurora.org>,
"bharatku@xilinx.com" <bharatku@xilinx.com>,
"ilias.apalodimas@linaro.org" <ilias.apalodimas@linaro.org>,
"shunyong.yang@hxt-semitech.com" <shunyong.yang@hxt-semitech.com>,
jacob.jun.pan@linux.intel.com
Subject: Re: [PATCH v3 03/10] iommu/sva: Manage process address spaces
Date: Mon, 15 Oct 2018 13:53:22 -0700 [thread overview]
Message-ID: <20181015135322.6c7f4797@jacob-builder> (raw)
In-Reply-To: <8ebfd3b5-9e16-85f6-a9f9-2627fb4b5b03@arm.com>
On Wed, 3 Oct 2018 18:52:16 +0100
Jean-Philippe Brucker <jean-philippe.brucker@arm.com> wrote:
> On 26/09/2018 23:35, Jacob Pan wrote:
> > On Thu, 20 Sep 2018 18:00:39 +0100
> > Jean-Philippe Brucker <jean-philippe.brucker@arm.com> wrote:
> >
> >> +
> >> +static int io_mm_attach(struct iommu_domain *domain, struct device
> >> *dev,
> >> + struct io_mm *io_mm, void *drvdata)
> >> +{
> >> + int ret;
> >> + bool attach_domain = true;
> >> + int pasid = io_mm->pasid;
> >> + struct iommu_bond *bond, *tmp;
> >> + struct iommu_sva_param *param =
> >> dev->iommu_param->sva_param; +
> >> + if (!domain->ops->mm_attach || !domain->ops->mm_detach)
> >> + return -ENODEV;
> >> +
> >> + if (pasid > param->max_pasid || pasid < param->min_pasid)
> >> + return -ERANGE;
> >> +
> >> + bond = kzalloc(sizeof(*bond), GFP_KERNEL);
> >> + if (!bond)
> >> + return -ENOMEM;
> >> +
> >> + bond->domain = domain;
> >> + bond->io_mm = io_mm;
> >> + bond->dev = dev;
> >> + bond->drvdata = drvdata;
> >> +
> >> + spin_lock(&iommu_sva_lock);
> >> + /*
> >> + * Check if this io_mm is already bound to the domain. In
> >> which case the
> >> + * IOMMU driver doesn't have to install the PASID table
> >> entry.
> >> + */
> >> + list_for_each_entry(tmp, &domain->mm_list, domain_head) {
> >> + if (tmp->io_mm == io_mm) {
> >> + attach_domain = false;
> >> + break;
> >> + }
> >> + }
> >> +
> >> + ret = domain->ops->mm_attach(domain, dev, io_mm,
> >> attach_domain);
> >> + if (ret) {
> >> + kfree(bond);
> >> + goto out_unlock;
> >> + }
> >> +
> >> + list_add(&bond->mm_head, &io_mm->devices);
> >> + list_add(&bond->domain_head, &domain->mm_list);
> >> + list_add(&bond->dev_head, ¶m->mm_list);
> >> +
> >
> > I am trying to understand if mm_list is needed for both per device
> > and per domain. Do you always unbind and detach domain? Seems
> > device could use the domain->mm_list to track all mm's, true?
>
> We need to track bonds per devices, since the bind/unbind() user
> interface in on devices. Tracking per domain is just a helper, so
> IOMMU drivers that have a single PASID table per domain know when
> they need to install a new entry (the attach_domain parameter above)
> and remove it. I think my code is wrong here: if binding two devices
> that are in the same domain to the same process we shouldn't add the
> io_mm to domain->mm_list twice.
>
> I'm still not sure if I should remove domains handling here though,
> could you confirm if you're planning to support
> iommu_get_domain_for_dev for vt-d?
>
yes. i am working on getting vt-d onto the same behavior in terms of
default domain. I have a patch being tested, we need to respect RMRR (
reserved region) that is setup before iommu_get_domain_for_dev().
> Thanks,
> Jean
[Jacob Pan]
next prev parent reply other threads:[~2018-10-15 20:51 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-20 17:00 [PATCH v3 00/10] Shared Virtual Addressing for the IOMMU Jean-Philippe Brucker
2018-09-20 17:00 ` [PATCH v3 01/10] iommu: Introduce Shared Virtual Addressing API Jean-Philippe Brucker
[not found] ` <f406bcf7-4e54-9f1b-88eb-03fc642ffede@linux.intel.com>
2018-09-24 12:07 ` Jean-Philippe Brucker
2018-09-25 13:16 ` Joerg Roedel
2018-09-25 22:46 ` Jacob Pan
2018-09-26 10:14 ` Jean-Philippe Brucker
2018-09-26 12:48 ` Joerg Roedel
2018-09-20 17:00 ` [PATCH v3 02/10] iommu/sva: Bind process address spaces to devices Jean-Philippe Brucker
2018-09-23 3:05 ` Lu Baolu
2018-09-24 12:07 ` Jean-Philippe Brucker
2018-09-26 18:01 ` Jacob Pan
2018-09-27 15:06 ` Jean-Philippe Brucker
2018-09-28 1:14 ` Tian, Kevin
2018-09-20 17:00 ` [PATCH v3 03/10] iommu/sva: Manage process address spaces Jean-Philippe Brucker
2018-09-25 3:15 ` Lu Baolu
2018-09-25 10:32 ` Jean-Philippe Brucker
2018-09-26 3:12 ` Lu Baolu
2018-09-25 13:26 ` Joerg Roedel
2018-09-25 23:33 ` Lu Baolu
2018-09-26 10:20 ` Jean-Philippe Brucker
2018-09-26 12:45 ` Joerg Roedel
2018-09-26 13:50 ` Jean-Philippe Brucker
2018-09-27 3:22 ` Liu, Yi L
2018-09-27 13:37 ` Jean-Philippe Brucker
2018-10-08 8:29 ` Liu, Yi L
2018-09-26 22:58 ` Jacob Pan
2018-09-26 22:35 ` Jacob Pan
2018-10-03 17:52 ` Jean-Philippe Brucker
2018-10-15 20:53 ` Jacob Pan [this message]
2018-09-20 17:00 ` [PATCH v3 04/10] iommu/sva: Add a mm_exit callback for device drivers Jean-Philippe Brucker
2018-09-20 17:00 ` [PATCH v3 05/10] iommu/sva: Track mm changes with an MMU notifier Jean-Philippe Brucker
2018-09-20 17:00 ` [PATCH v3 06/10] iommu/sva: Search mm by PASID Jean-Philippe Brucker
2018-09-25 4:59 ` Lu Baolu
2018-09-20 17:00 ` [PATCH v3 07/10] iommu: Add a page fault handler Jean-Philippe Brucker
2018-09-27 20:37 ` Jacob Pan
2018-10-03 17:46 ` Jean-Philippe Brucker
2018-09-20 17:00 ` [PATCH v3 08/10] iommu/iopf: Handle mm faults Jean-Philippe Brucker
2018-09-20 17:00 ` [PATCH v3 09/10] iommu/sva: Register page fault handler Jean-Philippe Brucker
2018-09-20 17:00 ` [RFC PATCH v3 10/10] iommu/sva: Add support for private PASIDs Jean-Philippe Brucker
2018-10-12 14:32 ` Jordan Crouse
2018-10-17 14:21 ` Jean-Philippe Brucker
2018-10-17 14:24 ` Jean-Philippe Brucker
2018-10-17 15:07 ` Jordan Crouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181015135322.6c7f4797@jacob-builder \
--to=jacob.jun.pan@linux.intel.com \
--cc=Andrew.Murray@arm.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=Robin.Murphy@arm.com \
--cc=Will.Deacon@arm.com \
--cc=alex.williamson@redhat.com \
--cc=ashok.raj@intel.com \
--cc=baolu.lu@linux.intel.com \
--cc=bharatku@xilinx.com \
--cc=christian.koenig@amd.com \
--cc=eric.auger@redhat.com \
--cc=ilias.apalodimas@linaro.org \
--cc=iommu@lists.linux-foundation.org \
--cc=jcrouse@codeaurora.org \
--cc=jean-philippe.brucker@arm.com \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=liguozhu@hisilicon.com \
--cc=linux-pci@vger.kernel.org \
--cc=okaya@codeaurora.org \
--cc=shunyong.yang@hxt-semitech.com \
--cc=xuzaibo@huawei.com \
--cc=yi.l.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).