* [PATCH] PCI: Remove unused attr variable in pci_dma_configure
@ 2018-12-15 1:49 Nathan Chancellor
2018-12-15 10:03 ` Christoph Hellwig
0 siblings, 1 reply; 2+ messages in thread
From: Nathan Chancellor @ 2018-12-15 1:49 UTC (permalink / raw)
To: Christoph Hellwig, Bjorn Helgaas
Cc: Robin Murphy, Jesper Dangaard Brouer, Rafael J . Wysocki,
Tony Luck, linux-pci, linux-kernel, Nathan Chancellor
Clang warns:
drivers/pci/pci-driver.c:1603:21: error: unused variable 'attr'
[-Werror,-Wunused-variable]
Commit e5361ca29f2f ("ACPI / scan: Refactor _CCA enforcement") removed
attr's use and replaced it with its assigned value so it is no longer
needed.
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
---
The commit that causes this warning is in Christoph's dma-mapping tree
so I assume this will go there too (roll it into it if need be).
drivers/pci/pci-driver.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/pci/pci-driver.c b/drivers/pci/pci-driver.c
index 1b58e058b13f..ea55444e6ead 100644
--- a/drivers/pci/pci-driver.c
+++ b/drivers/pci/pci-driver.c
@@ -1600,7 +1600,6 @@ static int pci_dma_configure(struct device *dev)
ret = of_dma_configure(dev, bridge->parent->of_node, true);
} else if (has_acpi_companion(bridge)) {
struct acpi_device *adev = to_acpi_device_node(bridge->fwnode);
- enum dev_dma_attr attr = acpi_get_dma_attr(adev);
ret = acpi_dma_configure(dev, acpi_get_dma_attr(adev));
}
--
2.20.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] PCI: Remove unused attr variable in pci_dma_configure
2018-12-15 1:49 [PATCH] PCI: Remove unused attr variable in pci_dma_configure Nathan Chancellor
@ 2018-12-15 10:03 ` Christoph Hellwig
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2018-12-15 10:03 UTC (permalink / raw)
To: Nathan Chancellor
Cc: Christoph Hellwig, Bjorn Helgaas, Robin Murphy,
Jesper Dangaard Brouer, Rafael J . Wysocki, Tony Luck, linux-pci,
linux-kernel
Thanks, applied.
FYI, this was my editing of Robins patch that I though I had undone
again, but only half so. Sorry.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-12-15 10:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-15 1:49 [PATCH] PCI: Remove unused attr variable in pci_dma_configure Nathan Chancellor
2018-12-15 10:03 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).