From: Bjorn Helgaas <helgaas@kernel.org>
To: Dave Hansen <dave.hansen@intel.com>
Cc: Jonathan Cameron <jonathan.cameron@huawei.com>,
linux-pci@vger.kernel.org, x86@kernel.org, linuxarm@huawei.com,
Ingo Molnar <mingo@kernel.org>,
Dave Hansen <dave.hansen@linux.intel.com>,
Andy Lutomirski <luto@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
martin@geanix.com
Subject: Re: [PATCH V2] x86: Fix an issue with invalid ACPI NUMA config
Date: Thu, 20 Dec 2018 13:57:14 -0600 [thread overview]
Message-ID: <20181220195714.GE183878@google.com> (raw)
In-Reply-To: <65f5bb93-b6be-d6dd-6976-e2761f6f2a7b@intel.com>
On Thu, Dec 20, 2018 at 09:13:12AM -0800, Dave Hansen wrote:
> On 12/20/18 7:12 AM, Bjorn Helgaas wrote:
> >> Other than the error we might be able to use acpi_map_pxm_to_online_node
> >> for this, or call both acpi_map_pxm_to_node and acpi_map_pxm_to_online_node
> >> and compare the answers to verify we are getting the node we want?
> > Where are we at with this? It'd be nice to resolve it for v4.21, but
> > it's a little out of my comfort zone, so I don't want to apply it
> > unless there's clear consensus that this is the right fix.
>
> I still think the fix in this patch sweeps the problem under the rug too
> much. But, it just might be the best single fix for backports, for
> instance.
Sounds like we should first find the best fix, then worry about how to
backport it. So I think we have a little more noodling to do, and
I'll defer this for now.
Bjorn
next prev parent reply other threads:[~2018-12-20 19:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-11 9:47 [PATCH V2] x86: Fix an issue with invalid ACPI NUMA config Jonathan Cameron
2018-12-11 18:19 ` Dave Hansen
2018-12-12 9:39 ` Jonathan Cameron
2018-12-20 15:12 ` Bjorn Helgaas
2018-12-20 17:13 ` Dave Hansen
2018-12-20 19:57 ` Bjorn Helgaas [this message]
2019-01-28 11:31 ` Jonathan Cameron
2019-01-28 23:13 ` Bjorn Helgaas
2019-01-29 9:51 ` Jonathan Cameron
2019-01-29 19:05 ` Bjorn Helgaas
2019-01-29 19:45 ` Jonathan Cameron
2019-01-29 21:10 ` Bjorn Helgaas
2019-02-07 10:12 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181220195714.GE183878@google.com \
--to=helgaas@kernel.org \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=jonathan.cameron@huawei.com \
--cc=linux-pci@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=luto@kernel.org \
--cc=martin@geanix.com \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).