From: Bjorn Helgaas <helgaas@kernel.org>
To: "Krzysztof Hałasa" <khalasa@piap.pl>
Cc: Rob Herring <robh@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
linux-pci@vger.kernel.org, Tim Harvey <tharvey@gateworks.com>,
Russell King <linux@armlinux.org.uk>,
stable@vger.kernel.org, Robin Leblon <robin.leblon@ncentric.com>,
Koen Vandeputte <koen.vandeputte@ncentric.com>,
Olof Johansson <olof@lixom.net>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm: cns3xxx: fix writing to wrong PCI registers after alignment
Date: Mon, 31 Dec 2018 09:29:18 -0600 [thread overview]
Message-ID: <20181231152918.GE159477@google.com> (raw)
In-Reply-To: <m336qegfzv.fsf@t19.piap.pl>
On Mon, Dec 31, 2018 at 11:14:28AM +0100, Krzysztof Hałasa wrote:
> Bjorn Helgaas <helgaas@kernel.org> writes:
>
> > 802b7c06adc7 replaced cns3xxx_pci_write_config(), which always used
> > __raw_writel() so it only did 32-bit accesses, with
> > pci_generic_config_write(), which uses writeb/writew/writel()
> > depending on the size.
> >
> > 802b7c06adc7 also converted cns3xxx_pci_read_config() from always
> > using __raw_readl() (a 32-bit access) to using
> > pci_generic_config_read32(), which also always does a 32-bit access.
> >
> > This makes me think the cnx3xxx hardware is only capable of 32-bit
> > accesses, and this patch should change the driver to use
> > pci_generic_config_write32() instead of pci_generic_config_write() in
> > addition to the mapping fix above.
>
> Hasn't it already been verified that the CNS3xxx can do 8-bit accesses
> (and probably 16-bit ones as well), and that the docs don't mention any
> such limitation?
Quite possibly. I'm not familiar with the hardware or docs so can't
comment personally.
802b7c06adc7 reimplemented cns3xxx_pci_read_config() using
pci_generic_config_read32(), which preserved the property of only
doing 32-bit reads. It replaced cns3xxx_pci_write_config() with
pci_generic_config_write(), so it changed writes from always being 32
bits to being the actual size. I think this was an error in the
original commit, since the changelog doesn't mention this change; in
fact, the changelog says it changes __raw_writel to writel.
The change from 32-bit to actual size accesses would logically be a
separate commit from changing to use the generic accessors.
Assuming the hardware does support smaller accesses, I'd propose two
patches:
1) The current one that corrects the address alignment error, and
2) A new one that converts cns3xxx_pci_read_config() to use
pci_generic_config_read() instead of pci_generic_config_read32().
Ideally the changelog for the second patch would refer to the
verification that the hardware is capable of 8- and 16-bit accesses.
Bjorn
next prev parent reply other threads:[~2018-12-31 15:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20181218111743.25566-1-koen.vandeputte@ncentric.com>
2018-12-30 1:06 ` [PATCH] arm: cns3xxx: fix writing to wrong PCI registers after alignment Bjorn Helgaas
2018-12-31 10:14 ` Krzysztof Hałasa
2018-12-31 15:29 ` Bjorn Helgaas [this message]
2019-01-07 8:58 ` Koen Vandeputte
2019-01-07 13:24 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181231152918.GE159477@google.com \
--to=helgaas@kernel.org \
--cc=arnd@arndb.de \
--cc=khalasa@piap.pl \
--cc=koen.vandeputte@ncentric.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=olof@lixom.net \
--cc=robh@kernel.org \
--cc=robin.leblon@ncentric.com \
--cc=stable@vger.kernel.org \
--cc=tharvey@gateworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).