linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] PCI: amlogic: fix build failure due to missing linux/gpio/consumer.h header
@ 2019-01-04  9:08 Corentin Labbe
  2019-01-04 10:30 ` Lorenzo Pieralisi
  0 siblings, 1 reply; 4+ messages in thread
From: Corentin Labbe @ 2019-01-04  9:08 UTC (permalink / raw)
  To: bhelgaas, khilman, lorenzo.pieralisi
  Cc: linux-amlogic, linux-arm-kernel, linux-kernel, linux-pci, Corentin Labbe

When building on x86, I got the following build failure:
drivers/pci/controller/dwc/pci-meson.c: In function ‘meson_pcie_assert_reset’:
drivers/pci/controller/dwc/pci-meson.c:290:2: error: implicit declaration of function ‘gpiod_set_value_cansleep’; did you mean ‘gpio_set_value_cansleep’? [-Werror=implicit-function-declaration]
  gpiod_set_value_cansleep(mp->reset_gpio, 0);
  ^~~~~~~~~~~~~~~~~~~~~~~~
  gpio_set_value_cansleep
drivers/pci/controller/dwc/pci-meson.c: In function ‘meson_pcie_probe’:
drivers/pci/controller/dwc/pci-meson.c:540:19: error: implicit declaration of function ‘devm_gpiod_get’; did you mean ‘devm_gpio_free’? [-Werror=implicit-function-declaration]
  mp->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW);
                   ^~~~~~~~~~~~~~
                   devm_gpio_free
drivers/pci/controller/dwc/pci-meson.c:540:48: error: ‘GPIOD_OUT_LOW’ undeclared (first use in this function); did you mean ‘GPIOF_INIT_LOW’?
  mp->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW);
                                                ^~~~~~~~~~~~~
                                                GPIOF_INIT_LOW

This is due to the missing linux/gpio/consumer.h header

Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
---
 drivers/pci/controller/dwc/pci-meson.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/pci/controller/dwc/pci-meson.c b/drivers/pci/controller/dwc/pci-meson.c
index 241ebe0c4505..e35e9eaa50ee 100644
--- a/drivers/pci/controller/dwc/pci-meson.c
+++ b/drivers/pci/controller/dwc/pci-meson.c
@@ -8,6 +8,7 @@
 
 #include <linux/clk.h>
 #include <linux/delay.h>
+#include <linux/gpio/consumer.h>
 #include <linux/of_device.h>
 #include <linux/of_gpio.h>
 #include <linux/pci.h>
-- 
2.19.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] PCI: amlogic: fix build failure due to missing linux/gpio/consumer.h header
  2019-01-04  9:08 [PATCH] PCI: amlogic: fix build failure due to missing linux/gpio/consumer.h header Corentin Labbe
@ 2019-01-04 10:30 ` Lorenzo Pieralisi
  2019-01-04 10:36   ` LABBE Corentin
  0 siblings, 1 reply; 4+ messages in thread
From: Lorenzo Pieralisi @ 2019-01-04 10:30 UTC (permalink / raw)
  To: Corentin Labbe
  Cc: bhelgaas, khilman, linux-amlogic, linux-arm-kernel, linux-kernel,
	linux-pci

On Fri, Jan 04, 2019 at 09:08:37AM +0000, Corentin Labbe wrote:
> When building on x86, I got the following build failure:

Hi,

what tree are you testing on and which config ?

Thanks,
Lorenzo

> drivers/pci/controller/dwc/pci-meson.c: In function ‘meson_pcie_assert_reset’:
> drivers/pci/controller/dwc/pci-meson.c:290:2: error: implicit declaration of function ‘gpiod_set_value_cansleep’; did you mean ‘gpio_set_value_cansleep’? [-Werror=implicit-function-declaration]
>   gpiod_set_value_cansleep(mp->reset_gpio, 0);
>   ^~~~~~~~~~~~~~~~~~~~~~~~
>   gpio_set_value_cansleep
> drivers/pci/controller/dwc/pci-meson.c: In function ‘meson_pcie_probe’:
> drivers/pci/controller/dwc/pci-meson.c:540:19: error: implicit declaration of function ‘devm_gpiod_get’; did you mean ‘devm_gpio_free’? [-Werror=implicit-function-declaration]
>   mp->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW);
>                    ^~~~~~~~~~~~~~
>                    devm_gpio_free
> drivers/pci/controller/dwc/pci-meson.c:540:48: error: ‘GPIOD_OUT_LOW’ undeclared (first use in this function); did you mean ‘GPIOF_INIT_LOW’?
>   mp->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW);
>                                                 ^~~~~~~~~~~~~
>                                                 GPIOF_INIT_LOW
> 
> This is due to the missing linux/gpio/consumer.h header
> 
> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
> ---
>  drivers/pci/controller/dwc/pci-meson.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/pci/controller/dwc/pci-meson.c b/drivers/pci/controller/dwc/pci-meson.c
> index 241ebe0c4505..e35e9eaa50ee 100644
> --- a/drivers/pci/controller/dwc/pci-meson.c
> +++ b/drivers/pci/controller/dwc/pci-meson.c
> @@ -8,6 +8,7 @@
>  
>  #include <linux/clk.h>
>  #include <linux/delay.h>
> +#include <linux/gpio/consumer.h>
>  #include <linux/of_device.h>
>  #include <linux/of_gpio.h>
>  #include <linux/pci.h>
> -- 
> 2.19.2
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] PCI: amlogic: fix build failure due to missing linux/gpio/consumer.h header
  2019-01-04 10:30 ` Lorenzo Pieralisi
@ 2019-01-04 10:36   ` LABBE Corentin
  2019-01-04 11:17     ` Lorenzo Pieralisi
  0 siblings, 1 reply; 4+ messages in thread
From: LABBE Corentin @ 2019-01-04 10:36 UTC (permalink / raw)
  To: Lorenzo Pieralisi
  Cc: bhelgaas, khilman, linux-amlogic, linux-arm-kernel, linux-kernel,
	linux-pci

On Fri, Jan 04, 2019 at 10:30:25AM +0000, Lorenzo Pieralisi wrote:
> On Fri, Jan 04, 2019 at 09:08:37AM +0000, Corentin Labbe wrote:
> > When building on x86, I got the following build failure:
> 
> Hi,
> 
> what tree are you testing on and which config ?

I use the next-20190102 tree
The config can be found at http://kernel.montjoie.ovh/configs/x86

Regards

> 
> Thanks,
> Lorenzo
> 
> > drivers/pci/controller/dwc/pci-meson.c: In function ‘meson_pcie_assert_reset’:
> > drivers/pci/controller/dwc/pci-meson.c:290:2: error: implicit declaration of function ‘gpiod_set_value_cansleep’; did you mean ‘gpio_set_value_cansleep’? [-Werror=implicit-function-declaration]
> >   gpiod_set_value_cansleep(mp->reset_gpio, 0);
> >   ^~~~~~~~~~~~~~~~~~~~~~~~
> >   gpio_set_value_cansleep
> > drivers/pci/controller/dwc/pci-meson.c: In function ‘meson_pcie_probe’:
> > drivers/pci/controller/dwc/pci-meson.c:540:19: error: implicit declaration of function ‘devm_gpiod_get’; did you mean ‘devm_gpio_free’? [-Werror=implicit-function-declaration]
> >   mp->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW);
> >                    ^~~~~~~~~~~~~~
> >                    devm_gpio_free
> > drivers/pci/controller/dwc/pci-meson.c:540:48: error: ‘GPIOD_OUT_LOW’ undeclared (first use in this function); did you mean ‘GPIOF_INIT_LOW’?
> >   mp->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW);
> >                                                 ^~~~~~~~~~~~~
> >                                                 GPIOF_INIT_LOW
> > 
> > This is due to the missing linux/gpio/consumer.h header
> > 
> > Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
> > ---
> >  drivers/pci/controller/dwc/pci-meson.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/pci/controller/dwc/pci-meson.c b/drivers/pci/controller/dwc/pci-meson.c
> > index 241ebe0c4505..e35e9eaa50ee 100644
> > --- a/drivers/pci/controller/dwc/pci-meson.c
> > +++ b/drivers/pci/controller/dwc/pci-meson.c
> > @@ -8,6 +8,7 @@
> >  
> >  #include <linux/clk.h>
> >  #include <linux/delay.h>
> > +#include <linux/gpio/consumer.h>
> >  #include <linux/of_device.h>
> >  #include <linux/of_gpio.h>
> >  #include <linux/pci.h>
> > -- 
> > 2.19.2
> > 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] PCI: amlogic: fix build failure due to missing linux/gpio/consumer.h header
  2019-01-04 10:36   ` LABBE Corentin
@ 2019-01-04 11:17     ` Lorenzo Pieralisi
  0 siblings, 0 replies; 4+ messages in thread
From: Lorenzo Pieralisi @ 2019-01-04 11:17 UTC (permalink / raw)
  To: LABBE Corentin
  Cc: bhelgaas, khilman, linux-amlogic, linux-arm-kernel, linux-kernel,
	linux-pci

On Fri, Jan 04, 2019 at 11:36:26AM +0100, LABBE Corentin wrote:
> On Fri, Jan 04, 2019 at 10:30:25AM +0000, Lorenzo Pieralisi wrote:
> > On Fri, Jan 04, 2019 at 09:08:37AM +0000, Corentin Labbe wrote:
> > > When building on x86, I got the following build failure:
> > 
> > Hi,
> > 
> > what tree are you testing on and which config ?
> 
> I use the next-20190102 tree
> The config can be found at http://kernel.montjoie.ovh/configs/x86

Ok, right, it is a config that unfortunately the bots failed to test, I
will pick this up and send it to Bjorn for -rc2 (given that the PCI tree
is not in mainline yet).

Thanks,
Lorenzo

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-01-04 11:17 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-04  9:08 [PATCH] PCI: amlogic: fix build failure due to missing linux/gpio/consumer.h header Corentin Labbe
2019-01-04 10:30 ` Lorenzo Pieralisi
2019-01-04 10:36   ` LABBE Corentin
2019-01-04 11:17     ` Lorenzo Pieralisi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).