From: Andrew Lunn <andrew@lunn.ch>
To: Baruch Siach <baruch@tkos.co.il>
Cc: linux-pwm@vger.kernel.org,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Sven Auhagen <sven.auhagen@voleatech.de>,
Jason Cooper <jason@lakedaemon.net>,
linux-gpio@vger.kernel.org, linux-pci@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Thierry Reding <thierry.reding@gmail.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Gregory Clement <gregory.clement@bootlin.com>,
linux-arm-kernel@lists.infradead.org,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH 2/2] PCI: armada8k: don't toggle reset twice
Date: Sun, 13 Jan 2019 16:40:28 +0100 [thread overview]
Message-ID: <20190113154028.GB4635@lunn.ch> (raw)
In-Reply-To: <87pnt0vil3.fsf@tarshish>
> Another look at this comment made me realize that we need comphy
> initialization support in the kernel for PCIe reset to work correctly.
>
> The workaround that this patch proposes will not solve the problem for
> v5.0, since the GPIO get_direction patch will only appear in v5.1.
You could ask for it to be applied to v5.0 since a real fix depends on
it.
We have a bit of a balancing act to sort out. The revert will fix
Macchiatobin. But i assume it breaks some other platforms which just
started to work. Ideally we want the best of both worlds. So maybe
getting the GPIO change into stable is the correct thing to do?
Andrew
next prev parent reply other threads:[~2019-01-13 15:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-10 12:26 [PATCH 1/2] gpio: mvebu: implement get_direction Baruch Siach
2019-01-10 12:26 ` [PATCH 2/2] PCI: armada8k: don't toggle reset twice Baruch Siach
2019-01-10 12:55 ` Andrew Lunn
2019-01-10 13:05 ` Baruch Siach
2019-01-10 13:19 ` Andrew Lunn
2019-01-10 15:57 ` Baruch Siach
2019-01-13 12:38 ` Baruch Siach
2019-01-13 15:40 ` Andrew Lunn [this message]
2019-01-13 18:42 ` Baruch Siach
2019-01-13 23:35 ` Linus Walleij
2019-01-14 7:19 ` Baruch Siach
2019-01-10 15:20 ` [PATCH 1/2] gpio: mvebu: implement get_direction Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190113154028.GB4635@lunn.ch \
--to=andrew@lunn.ch \
--cc=baruch@tkos.co.il \
--cc=bgolaszewski@baylibre.com \
--cc=bhelgaas@google.com \
--cc=gregory.clement@bootlin.com \
--cc=jason@lakedaemon.net \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=sebastian.hesselbarth@gmail.com \
--cc=sven.auhagen@voleatech.de \
--cc=thierry.reding@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).