From: Dan Carpenter <dan.carpenter@oracle.com>
To: Ajay Kaher <akaher@vmware.com>
Cc: linux-pci@vger.kernel.org, haiyangz@microsoft.com,
linux-kernel@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
devel@linuxdriverproject.org
Subject: Re: [PATCH 1/3] PCI: hv: Allocate physically contiguous hypercall params buffer
Date: Mon, 21 Jan 2019 16:36:28 +0300 [thread overview]
Message-ID: <20190121133628.GI4482@kadam> (raw)
In-Reply-To: <20190121131942.GH4482@kadam>
On Mon, Jan 21, 2019 at 04:19:42PM +0300, Dan Carpenter wrote:
> On Fri, Jan 18, 2019 at 02:17:16AM +0530, Ajay Kaher wrote:
> > hv_do_hypercall() assumes that we pass a segment from a physically
> > contiguous buffer. A buffer allocated on the stack may not work if
> > CONFIG_VMAP_STACK=y is set.
> >
> > Use kmalloc() to allocate this buffer.
> >
>
> Since you're going to need to resend this anyway, can you add in the
> commit message what this looks like from a user perspective? Presumably
> it's an occasional crash?
>
Never mind. I didn't realize this was a two year old patch.
regards,
dan carpenter
next prev parent reply other threads:[~2019-01-21 13:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-17 20:47 [PATCH 0/3] PCI: hv: Use vPCI protocol version 1.2 for v4.9 Ajay Kaher
2019-01-17 13:21 ` Greg KH
2019-01-17 20:47 ` [PATCH 1/3] PCI: hv: Allocate physically contiguous hypercall params buffer Ajay Kaher
2019-01-17 14:57 ` Bjorn Helgaas
2019-01-21 13:19 ` Dan Carpenter
2019-01-21 13:36 ` Dan Carpenter [this message]
2019-01-17 20:47 ` [PATCH 2/3] PCI: hv: Add vPCI version protocol negotiation Ajay Kaher
2019-01-17 14:59 ` Bjorn Helgaas
2019-01-17 20:47 ` [PATCH 3/3] PCI: hv: Use vPCI protocol version 1.2 for v4.9 Ajay Kaher
2019-01-17 15:06 ` Bjorn Helgaas
2019-01-18 14:05 ` Ajay Kaher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190121133628.GI4482@kadam \
--to=dan.carpenter@oracle.com \
--cc=akaher@vmware.com \
--cc=bhelgaas@google.com \
--cc=devel@linuxdriverproject.org \
--cc=haiyangz@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).