From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EEEFC169C4 for ; Tue, 29 Jan 2019 19:06:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 543D421848 for ; Tue, 29 Jan 2019 19:06:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1548788761; bh=C/ElWr39C7348LPT6M9EQw73AUPUHuuyi4qzDK3KsaE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=Zz3zOZAsz7oH1moGvmsyNZMyspMexGjCMnXz9/VceR4flVeLGJWDYcAsKrBniZIxH mQHlso0gctxDR1ZBii1fid2Q7t4i9DyHM3/8PwklD2QnRORxi83CDodjYfXopsqVgq W7EQ7UI4aAd9cEaZscAcv6R13nsRdGDdzeMBd/00= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727068AbfA2TGA (ORCPT ); Tue, 29 Jan 2019 14:06:00 -0500 Received: from mail.kernel.org ([198.145.29.99]:34644 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726984AbfA2TGA (ORCPT ); Tue, 29 Jan 2019 14:06:00 -0500 Received: from localhost (156.sub-174-234-151.myvzw.com [174.234.151.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A307920844; Tue, 29 Jan 2019 19:05:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1548788759; bh=C/ElWr39C7348LPT6M9EQw73AUPUHuuyi4qzDK3KsaE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GukueZtyeyVUCdD3XNXwmMmJWPqwXf7xLKyMITqxaEU1I8qWgjsoNgvQELWnYv2Ek UgYIpgB3sZjZfcJvJ6uIrB3wRHMpp764N+VXhzVXQPI2M7R8LXQ9j6HLFQeTZ0NgpH BaZaUi4Rj09eNxdClryXzPSMhP0W15xYwlq9e9CM= Date: Tue, 29 Jan 2019 13:05:56 -0600 From: Bjorn Helgaas To: Jonathan Cameron Cc: Dave Hansen , linux-pci@vger.kernel.org, x86@kernel.org, linuxarm@huawei.com, Ingo Molnar , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Martin =?iso-8859-1?Q?Hundeb=F8ll?= , Linux Memory Management List , ACPI Devel Mailing List Subject: Re: [PATCH V2] x86: Fix an issue with invalid ACPI NUMA config Message-ID: <20190129190556.GB91506@google.com> References: <20181211094737.71554-1-Jonathan.Cameron@huawei.com> <20181212093914.00002aed@huawei.com> <20181220151225.GB183878@google.com> <65f5bb93-b6be-d6dd-6976-e2761f6f2a7b@intel.com> <20181220195714.GE183878@google.com> <20190128112904.0000461a@huawei.com> <20190128231322.GA91506@google.com> <20190129095105.00000374@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190129095105.00000374@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Tue, Jan 29, 2019 at 09:51:05AM +0000, Jonathan Cameron wrote: > On Mon, 28 Jan 2019 17:13:22 -0600 > Bjorn Helgaas wrote: > > On Mon, Jan 28, 2019 at 11:31:08AM +0000, Jonathan Cameron wrote: > > > On Thu, 20 Dec 2018 13:57:14 -0600 > > > Bjorn Helgaas wrote: > > > > On Thu, Dec 20, 2018 at 09:13:12AM -0800, Dave Hansen wrote: > > > > > On 12/20/18 7:12 AM, Bjorn Helgaas wrote: > > The current patch proposes setting "numa_off=1" in the x86 version of > > dummy_numa_init(), on the assumption (from the changelog) that: > > > > It is invalid under the ACPI spec to specify new NUMA nodes using > > _PXM if they have no presence in SRAT. > > > > Do you have a reference for this? I looked and couldn't find a clear > > statement in the spec to that effect. The _PXM description (ACPI > > v6.2, sec 6.1.14) says that two devices with the same _PXM value are > > in the same proximity domain, but it doesn't seem to require an SRAT. > > No comment (feel free to guess why). *sigh* Secret interpretations of the spec are out of bounds. But I think it's a waste of time to argue about whether _PXM without SRAT is valid. Systems like that exist, and I think it's possible to do something sensible with them. > > Maybe it results in an issue when we call kmalloc_node() using this > > _PXM value that SRAT didn't tell us about? If so, that's reminiscent > > of these earlier discussions about kmalloc_node() returning something > > useless if the requested node is not online: > > > > https://lkml.kernel.org/r/1527768879-88161-2-git-send-email-xiexiuqi@huawei.com > > https://lore.kernel.org/linux-arm-kernel/20180801173132.19739-1-punit.agrawal@arm.com/ > > > > As far as I know, that was never really resolved. The immediate > > problem of using passing an invalid node number to kmalloc_node() was > > avoided by using kmalloc() instead. > > Yes, that's definitely still a problem (or was last time I checked) > > > > Dave's response was that we needed to fix the underlying issue of > > > trying to allocate from non existent NUMA nodes. > > Bottom line, I totally agree that it would be better to fix the > > underlying issue without trying to avoid it by disabling NUMA. > > I don't agree on this point. I think two layers make sense. > > If there is no NUMA description in DT or ACPI, why not just stop anything > from using it at all? The firmware has basically declared there is no > point, why not save a bit of complexity (and use an existing tested code > path) but setting numa_off? Firmware with a _PXM does have a NUMA description. > However, if there is NUMA description, but with bugs then we should > protect in depth. A simple example being that we declare 2 nodes, but > then use _PXM for a third. I've done that by accident and blows up > in a nasty fashion (not done it for a while, but probably still true). > > Given DSDT is only parsed long after SRAT we can just check on _PXM > queries. Or I suppose we could do a verification parse for all _PXM > entries and put out some warnings if they don't match SRAT entries? I'm assuming the crash happens when we call kmalloc_node() with a node not mentioned in SRAT. I think that's just sub-optimal implementation in kmalloc_node(). We *could* fail the allocation and return a NULL pointer, but I think even that is excessive. I think we should simply fall back to kmalloc(). We could print a one-time warning if that's useful. If kmalloc_node() for an unknown node fell back to kmalloc(), would anything else be required? > > > Whilst I agree with that in principle (having managed to provide > > > tables doing exactly that during development a few times!), I'm not > > > sure the path to doing so is clear and so this has been stalled for > > > a few months. There is to my mind still a strong argument, even > > > with such protection in place, that we should still be short cutting > > > it so that you get the same paths if you deliberately disable numa, > > > and if you have no SRAT and hence can't have NUMA. > > > > I guess we need to resolve the question of whether NUMA without SRAT > > is possible. > > It's certainly unclear of whether it has any meaning. If we allow for > the fact that the intent of ACPI was never to allow this (and a bit > of history checking verified this as best as anyone can remember), > then what do we do with the few platforms that do use _PXM to nodes that > haven't been defined? We *could* ignore any _PXM that mentions a proximity domain not mentioned by an SRAT. That seems a little heavy-handed because it means every possible proximity domain must be described up front in the SRAT, which limits the flexibility of hot-adding entire nodes (CPU/memory/IO). But I think it's possible to make sense of a _PXM that adds a proximity domain not mentioned in an SRAT, e.g., if a new memory device and a new I/O device supply the same _PXM value, we can assume they're close together. If a new I/O device has a previously unknown _PXM, we may not be able to allocate memory near it, but we should at least be able to allocate from a default zone. Bjorn