From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Stefan Agner <stefan@agner.ch>
Cc: jingoohan1@gmail.com, gustavo.pimentel@synopsys.com,
l.stach@pengutronix.de, tpiepho@impinj.com,
leonard.crestez@nxp.com, bhelgaas@google.com,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/3] PCI: dwc: allow to limit registers set length
Date: Fri, 1 Feb 2019 17:13:49 +0000 [thread overview]
Message-ID: <20190201171349.GC22887@e107981-ln.cambridge.arm.com> (raw)
In-Reply-To: <f4f731d928293406e093ae9b23583510@agner.ch>
On Thu, Jan 31, 2019 at 10:08:11AM +0100, Stefan Agner wrote:
> On 30.01.2019 18:54, Lorenzo Pieralisi wrote:
> > On Tue, Dec 04, 2018 at 05:55:26PM +0100, Stefan Agner wrote:
> >> Add length to the struct dw_pcie and check that the accessors
> >> dw_pcie_(rd|wr)_conf() do not read/write beyond that point.
> >>
> >> Suggested-by: Trent Piepho <tpiepho@impinj.com>
> >> Signed-off-by: Stefan Agner <stefan@agner.ch>
> >> ---
> >> Changes in v4:
> >> - Move length check to dw_pcie_rd_conf
> >>
> >> .../pci/controller/dwc/pcie-designware-host.c | 16 ++++++++++++++--
> >> drivers/pci/controller/dwc/pcie-designware.h | 1 +
> >> 2 files changed, 15 insertions(+), 2 deletions(-)
> >
> > Hi Stefan,
> >
> > I wanted to ask you if this series should be considered for v5.1
> > inclusion, it is in the PCI backlog. If it is, let me have a look
> > and if it is OK to go I will likely ask you to rebase it.
>
> Yes please. With this last change I did not see any regression anymore
> so far.
>
> Andrey Smirnov picked up the second patch: "PCI: imx6: introduce
> drvdata". Not sure what the plan is with his patchset, if it gets merged
> into v5.1 too then I probably better drop this patch and rebase ontop of
> his series.
Ok, I will get back to you when I merged Andrey's series so that you
can rebase on top of my pci/dwc branch with Andrey's patches applied.
Lorenzo
next prev parent reply other threads:[~2019-02-01 17:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-04 16:55 [PATCH v4 1/3] PCI: dwc: allow to limit registers set length Stefan Agner
2018-12-04 16:55 ` [PATCH v4 2/3] PCI: imx6: introduce drvdata Stefan Agner
2018-12-04 16:55 ` [PATCH v4 3/3] PCI: imx6: limit DBI register length Stefan Agner
2018-12-04 19:08 ` Leonard Crestez
2019-01-30 17:54 ` [PATCH v4 1/3] PCI: dwc: allow to limit registers set length Lorenzo Pieralisi
2019-01-31 9:08 ` Stefan Agner
2019-02-01 17:13 ` Lorenzo Pieralisi [this message]
2019-02-04 12:27 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190201171349.GC22887@e107981-ln.cambridge.arm.com \
--to=lorenzo.pieralisi@arm.com \
--cc=bhelgaas@google.com \
--cc=gustavo.pimentel@synopsys.com \
--cc=jingoohan1@gmail.com \
--cc=l.stach@pengutronix.de \
--cc=leonard.crestez@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=stefan@agner.ch \
--cc=tpiepho@impinj.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).