linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sergey Miroshnichenko <s.miroshnichenko@yadro.com>
To: <linux-pci@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
	Rajat Jain <rajatja@google.com>, <linux@yadro.com>,
	Sergey Miroshnichenko <s.miroshnichenko@yadro.com>,
	<linuxppc-dev@lists.ozlabs.org>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Oliver <oohall@gmail.com>, Sam Bobroff <sbobroff@linux.ibm.com>
Subject: [PATCH RFC v3 21/21] powerpc/pci: Fix crash with enabled movable BARs
Date: Mon, 4 Feb 2019 18:36:01 +0300	[thread overview]
Message-ID: <20190204153601.7576-22-s.miroshnichenko@yadro.com> (raw)
In-Reply-To: <20190204153601.7576-1-s.miroshnichenko@yadro.com>

Check a resource for the UNSET flags.

Signed-off-by: Sergey Miroshnichenko <s.miroshnichenko@yadro.com>
---
 arch/powerpc/platforms/powernv/pci-ioda.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/powerpc/platforms/powernv/pci-ioda.c b/arch/powerpc/platforms/powernv/pci-ioda.c
index 7db3119f8a5b..5354dfdf1028 100644
--- a/arch/powerpc/platforms/powernv/pci-ioda.c
+++ b/arch/powerpc/platforms/powernv/pci-ioda.c
@@ -3038,7 +3038,8 @@ static void pnv_ioda_setup_pe_res(struct pnv_ioda_pe *pe,
 	int index;
 	int64_t rc;
 
-	if (!res || !res->flags || res->start > res->end)
+	if (!res || !res->flags || res->start > res->end ||
+	    (res->flags & IORESOURCE_UNSET))
 		return;
 
 	if (res->flags & IORESOURCE_IO) {
-- 
2.20.1


      parent reply	other threads:[~2019-02-04 15:36 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-04 15:35 [PATCH RFC v3 00/21] PCI: Allow BAR movement during hotplug Sergey Miroshnichenko
2019-02-04 15:35 ` [PATCH RFC v3 01/21] PCI: Fix writing invalid BARs during pci_restore_state() Sergey Miroshnichenko
2019-02-04 15:35 ` [PATCH RFC v3 02/21] PCI: Fix race condition in pci_enable/disable_device() Sergey Miroshnichenko
2019-02-04 15:35 ` [PATCH RFC v3 03/21] PCI: Enable bridge's I/O and MEM access for hotplugged devices Sergey Miroshnichenko
2019-02-04 15:35 ` [PATCH RFC v3 04/21] PCI: Define PCI-specific version of the release_child_resources() Sergey Miroshnichenko
2019-02-04 15:35 ` [PATCH RFC v3 05/21] PCI: hotplug: Add a flag for the movable BARs feature Sergey Miroshnichenko
2019-02-04 15:35 ` [PATCH RFC v3 06/21] PCI: Pause the devices with movable BARs during rescan Sergey Miroshnichenko
2019-02-04 15:35 ` [PATCH RFC v3 07/21] PCI: Wake up bridges during rescan when movable BARs enabled Sergey Miroshnichenko
2019-02-04 15:35 ` [PATCH RFC v3 08/21] nvme-pci: Handle movable BARs Sergey Miroshnichenko
2019-02-04 15:35 ` [PATCH RFC v3 09/21] PCI: Mark immovable BARs with PCI_FIXED Sergey Miroshnichenko
2019-02-04 15:35 ` [PATCH RFC v3 10/21] PCI: Fix assigning of fixed prefetchable resources Sergey Miroshnichenko
2019-02-04 15:35 ` [PATCH RFC v3 11/21] PCI: Release and reassign the root bridge resources during rescan Sergey Miroshnichenko
2019-02-04 15:35 ` [PATCH RFC v3 12/21] PCI: Don't allow hotplugged devices to steal resources Sergey Miroshnichenko
2019-02-04 15:35 ` [PATCH RFC v3 13/21] PCI: Include fixed BARs into the bus size calculating Sergey Miroshnichenko
2019-02-04 15:35 ` [PATCH RFC v3 14/21] PCI: Don't reserve memory for hotplug when enabled movable BARs Sergey Miroshnichenko
2019-02-04 15:35 ` [PATCH RFC v3 15/21] PCI: Allow the failed resources to be reassigned later Sergey Miroshnichenko
2019-02-04 15:35 ` [PATCH RFC v3 16/21] PCI: Calculate fixed areas of bridge windows based on fixed BARs Sergey Miroshnichenko
2019-02-04 15:35 ` [PATCH RFC v3 17/21] PCI: Calculate boundaries for bridge windows Sergey Miroshnichenko
2019-02-04 15:35 ` [PATCH RFC v3 18/21] PCI: Make sure bridge windows include their fixed BARs Sergey Miroshnichenko
2019-02-04 15:35 ` [PATCH RFC v3 19/21] PCI: Prioritize fixed BAR assigning over the movable ones Sergey Miroshnichenko
2019-02-04 15:36 ` [PATCH RFC v3 20/21] PCI: pciehp: Add support for the movable BARs feature Sergey Miroshnichenko
2019-02-04 15:36 ` Sergey Miroshnichenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190204153601.7576-22-s.miroshnichenko@yadro.com \
    --to=s.miroshnichenko@yadro.com \
    --cc=benh@kernel.crashing.org \
    --cc=helgaas@kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux@yadro.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=oohall@gmail.com \
    --cc=rajatja@google.com \
    --cc=sbobroff@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).