From: "Raj, Ashok" <ashok.raj@intel.com>
To: Sinan Kaya <Okaya@kernel.org>
Cc: sathyanarayanan.kuppuswamy@linux.intel.com, bhelgaas@google.com,
joro@8bytes.org, dwmw2@infradead.org, linux-pci@vger.kernel.org,
iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
Jacob Pan <jacob.jun.pan@linux.intel.com>,
Keith Busch <keith.busch@intel.com>,
Ashok Raj <ashok.raj@intel.com>
Subject: Re: [PATCH v1 1/2] PCI: ATS: Add function to check ATS page aligned request status.
Date: Mon, 11 Feb 2019 11:15:50 -0800 [thread overview]
Message-ID: <20190211191549.GA12090@otc-nc-03> (raw)
In-Reply-To: <815f2621-fc28-bff4-c300-cce7514cfe71@kernel.org>
On Fri, Feb 08, 2019 at 11:49:55PM -0500, Sinan Kaya wrote:
> On 2/8/2019 8:02 PM, sathyanarayanan kuppuswamy wrote:
> >>This means that you should probably have some kind of version check
> >>here.
> >
> >There is no version field in ATS v1.0 spec. Also, If I follow the history
> >log in PCI spec, I think ATS if first added at v1.2. Please correct me if
> >I am wrong.
>
> v1.2 was incorporated into PCIe spec at that time. However, the ATS spec
> is old and there could be some HW that could claim to be ATS compatible.
> I know AMD GPUs declare ATS capability.
It seems rather odd we have to check for ATS version.
I always assumed unspecified bits (Reserved) must be 0. We only check
this if ATS is enabled, and this particular bit wasn't given away for another
feature.
Is it really required to check for ATS version before consuming this?
>
> See this ECN
>
> https://composter.com.ua/documents/ats_r1.1_26Jan09.pdf
>
> You need to validate the version field from ATS capability header to be
> 1 before reading this register.
>
> See Table 5-1: ATS Extended Capability Header
next prev parent reply other threads:[~2019-02-11 19:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-07 18:41 [PATCH v1 0/2] Add page alignment check in Intel IOMMU sathyanarayanan.kuppuswamy
2019-02-07 18:41 ` [PATCH v1 1/2] PCI: ATS: Add function to check ATS page aligned request status sathyanarayanan.kuppuswamy
2019-02-07 20:07 ` Bjorn Helgaas
2019-02-07 20:39 ` sathyanarayanan kuppuswamy
2019-02-07 20:38 ` Sinan Kaya
2019-02-07 22:16 ` sathyanarayanan kuppuswamy
2019-02-08 1:58 ` Sinan Kaya
2019-02-09 1:02 ` sathyanarayanan kuppuswamy
2019-02-09 4:49 ` Sinan Kaya
2019-02-11 19:15 ` Raj, Ashok [this message]
2019-02-11 19:24 ` sathyanarayanan kuppuswamy
2019-02-11 20:35 ` Sinan Kaya
2019-02-07 18:41 ` [PATCH v1 2/2] iommu/vt-d: Enable ATS only if the device uses page aligned address sathyanarayanan.kuppuswamy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190211191549.GA12090@otc-nc-03 \
--to=ashok.raj@intel.com \
--cc=Okaya@kernel.org \
--cc=bhelgaas@google.com \
--cc=dwmw2@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=jacob.jun.pan@linux.intel.com \
--cc=joro@8bytes.org \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).