From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: Stanimir Varbanov <svarbanov@mm-sol.com>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org,
Khasim Syed Mohammed <khasim.mohammed@linaro.org>,
Niklas Cassel <niklas.cassel@linaro.org>,
stable@vger.kernel.org
Subject: Re: [PATCH] PCI: qcom: Don't deassert reset GPIO during probe
Date: Mon, 18 Feb 2019 21:16:03 -0800 [thread overview]
Message-ID: <20190219051602.GB13018@tuxbook-pro> (raw)
In-Reply-To: <20190213152352.GB417@e107981-ln.cambridge.arm.com>
On Wed 13 Feb 07:23 PST 2019, Lorenzo Pieralisi wrote:
> On Fri, Jan 25, 2019 at 03:26:16PM -0800, Bjorn Andersson wrote:
> > Acquiring the reset GPIO low means that reset is being deasserted, this
> > is followed almost immediately with qcom_pcie_host_init() asserting it,
> > initializing it and then finally deasserting it again, for the link to
> > come up.
> >
> > Some PCIe devices requires a minimum time between the initial deassert
> > and subsequent reset cycles. In a platform that boots with the reset
> > GPIO asserted this requirement is being violated by this deassert/assert
> > pulse.
> >
> > Acquiring the reset GPIO high will prevent this by matching the state to
> > the subsequent asserted state.
> >
> > Cc: stable@vger.kernel.org
>
> Missing Fixes: tag, please provide me one so that I can proceed.
>
This applies to the original commit introducing this driver, so:
Fixes: 82a823833f4e ("PCI: qcom: Add Qualcomm PCIe controller driver")
Regards,
Bjorn
next prev parent reply other threads:[~2019-02-19 5:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-25 23:26 [PATCH] PCI: qcom: Don't deassert reset GPIO during probe Bjorn Andersson
2019-02-08 14:54 ` Stanimir Varbanov
2019-02-13 15:23 ` Lorenzo Pieralisi
2019-02-19 5:16 ` Bjorn Andersson [this message]
2019-02-19 11:10 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190219051602.GB13018@tuxbook-pro \
--to=bjorn.andersson@linaro.org \
--cc=bhelgaas@google.com \
--cc=khasim.mohammed@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=niklas.cassel@linaro.org \
--cc=stable@vger.kernel.org \
--cc=svarbanov@mm-sol.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).