From: Simon Horman <horms@verge.net.au>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: marek.vasut@gmail.com, linux-pci@vger.kernel.org,
Kazufumi Ikeda <kaz-ikeda@xc.jp.nec.com>,
Gaku Inami <gaku.inami.xw@bp.renesas.com>,
Marek Vasut <marek.vasut+renesas@gmail.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Phil Edworthy <phil.edworthy@renesas.com>,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH V2] PCI: rcar: Add the initialization of PCIe link in resume_noirq
Date: Mon, 25 Feb 2019 10:58:48 +0100 [thread overview]
Message-ID: <20190225095847.53fppllriqc4yg36@verge.net.au> (raw)
In-Reply-To: <20190219172420.d4reyw3zwgmc3a7g@ninjato>
On Tue, Feb 19, 2019 at 06:24:20PM +0100, Wolfram Sang wrote:
> On Sun, Feb 17, 2019 at 02:24:41PM +0100, marek.vasut@gmail.com wrote:
> > From: Kazufumi Ikeda <kaz-ikeda@xc.jp.nec.com>
> >
> > Reestablish the PCIe link very early in the resume process in case it
> > went down to prevent PCI accesses from hanging the bus. Such accesses
> > can happen early in the PCI resume process, in the resume_noirq, thus
> > the link must be reestablished in the resume_noirq callback of the
> > driver.
> >
> > Signed-off-by: Kazufumi Ikeda <kaz-ikeda@xc.jp.nec.com>
> > Signed-off-by: Gaku Inami <gaku.inami.xw@bp.renesas.com>
> > Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
>
> I am not a deep PCI expert. Still, the patch looks good to me and I
> double checked with the documentation.
>
> Acked-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
>
> Minor nit would be 'CONFIG_PM' protection around the new code. But I
> have no strong opinion on that.
I agree that would be a nice enhancement but I also do not feel strongly
about it.
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
next prev parent reply other threads:[~2019-02-25 9:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-17 13:24 [PATCH V2] PCI: rcar: Add the initialization of PCIe link in resume_noirq marek.vasut
2019-02-19 17:24 ` Wolfram Sang
2019-02-25 9:58 ` Simon Horman [this message]
2019-03-07 20:50 ` Bjorn Helgaas
2019-03-07 22:49 ` Marek Vasut
2019-03-08 17:17 ` Bjorn Helgaas
2019-03-08 21:35 ` Marek Vasut
2019-03-11 10:10 ` Rafael J. Wysocki
2019-03-19 16:18 ` Lorenzo Pieralisi
2019-03-22 11:31 ` Lorenzo Pieralisi
2019-03-22 12:09 ` Marek Vasut
2019-03-22 12:18 ` Lorenzo Pieralisi
2019-03-22 12:29 ` Geert Uytterhoeven
2019-03-22 12:33 ` Marek Vasut
2019-03-22 12:42 ` Geert Uytterhoeven
2019-03-22 12:49 ` Marek Vasut
2019-03-25 16:54 ` Lorenzo Pieralisi
2019-03-25 19:44 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190225095847.53fppllriqc4yg36@verge.net.au \
--to=horms@verge.net.au \
--cc=gaku.inami.xw@bp.renesas.com \
--cc=geert+renesas@glider.be \
--cc=kaz-ikeda@xc.jp.nec.com \
--cc=linux-pci@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=marek.vasut+renesas@gmail.com \
--cc=marek.vasut@gmail.com \
--cc=phil.edworthy@renesas.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).