* [PATCH -next] PCI: aardvark: Make symbol 'advk_pci_bridge_emul_ops' static
@ 2019-03-01 6:58 Wei Yongjun
2019-03-01 7:25 ` Thomas Petazzoni
2019-03-01 15:29 ` Lorenzo Pieralisi
0 siblings, 2 replies; 3+ messages in thread
From: Wei Yongjun @ 2019-03-01 6:58 UTC (permalink / raw)
To: Thomas Petazzoni, Lorenzo Pieralisi, Bjorn Helgaas, Zachary Zhang
Cc: Wei Yongjun, linux-pci, linux-arm-kernel, kernel-janitors
Fixes the following sparse warning:
drivers/pci/controller/pci-aardvark.c:469:28: warning:
symbol 'advk_pci_bridge_emul_ops' was not declared. Should it be static?
Fixes: 8a3ebd8de328 ("PCI: aardvark: Implement emulated root PCI bridge config space")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/pci/controller/pci-aardvark.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/controller/pci-aardvark.c b/drivers/pci/controller/pci-aardvark.c
index 6eecae447af3..eb58dfdaba1b 100644
--- a/drivers/pci/controller/pci-aardvark.c
+++ b/drivers/pci/controller/pci-aardvark.c
@@ -466,7 +466,7 @@ advk_pci_bridge_emul_pcie_conf_write(struct pci_bridge_emul *bridge,
}
}
-struct pci_bridge_emul_ops advk_pci_bridge_emul_ops = {
+static struct pci_bridge_emul_ops advk_pci_bridge_emul_ops = {
.read_pcie = advk_pci_bridge_emul_pcie_conf_read,
.write_pcie = advk_pci_bridge_emul_pcie_conf_write,
};
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] PCI: aardvark: Make symbol 'advk_pci_bridge_emul_ops' static
2019-03-01 6:58 [PATCH -next] PCI: aardvark: Make symbol 'advk_pci_bridge_emul_ops' static Wei Yongjun
@ 2019-03-01 7:25 ` Thomas Petazzoni
2019-03-01 15:29 ` Lorenzo Pieralisi
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2019-03-01 7:25 UTC (permalink / raw)
To: Wei Yongjun
Cc: Lorenzo Pieralisi, Bjorn Helgaas, Zachary Zhang, linux-pci,
linux-arm-kernel, kernel-janitors
Hello Wei,
On Fri, 1 Mar 2019 06:58:09 +0000
Wei Yongjun <weiyongjun1@huawei.com> wrote:
> Fixes the following sparse warning:
>
> drivers/pci/controller/pci-aardvark.c:469:28: warning:
> symbol 'advk_pci_bridge_emul_ops' was not declared. Should it be static?
>
> Fixes: 8a3ebd8de328 ("PCI: aardvark: Implement emulated root PCI bridge config space")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] PCI: aardvark: Make symbol 'advk_pci_bridge_emul_ops' static
2019-03-01 6:58 [PATCH -next] PCI: aardvark: Make symbol 'advk_pci_bridge_emul_ops' static Wei Yongjun
2019-03-01 7:25 ` Thomas Petazzoni
@ 2019-03-01 15:29 ` Lorenzo Pieralisi
1 sibling, 0 replies; 3+ messages in thread
From: Lorenzo Pieralisi @ 2019-03-01 15:29 UTC (permalink / raw)
To: Wei Yongjun
Cc: Thomas Petazzoni, Bjorn Helgaas, Zachary Zhang, linux-pci,
linux-arm-kernel, kernel-janitors
On Fri, Mar 01, 2019 at 06:58:09AM +0000, Wei Yongjun wrote:
> Fixes the following sparse warning:
>
> drivers/pci/controller/pci-aardvark.c:469:28: warning:
> symbol 'advk_pci_bridge_emul_ops' was not declared. Should it be static?
>
> Fixes: 8a3ebd8de328 ("PCI: aardvark: Implement emulated root PCI bridge config space")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/pci/controller/pci-aardvark.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to pci/misc for v5.1, thanks.
Lorenzo
> diff --git a/drivers/pci/controller/pci-aardvark.c b/drivers/pci/controller/pci-aardvark.c
> index 6eecae447af3..eb58dfdaba1b 100644
> --- a/drivers/pci/controller/pci-aardvark.c
> +++ b/drivers/pci/controller/pci-aardvark.c
> @@ -466,7 +466,7 @@ advk_pci_bridge_emul_pcie_conf_write(struct pci_bridge_emul *bridge,
> }
> }
>
> -struct pci_bridge_emul_ops advk_pci_bridge_emul_ops = {
> +static struct pci_bridge_emul_ops advk_pci_bridge_emul_ops = {
> .read_pcie = advk_pci_bridge_emul_pcie_conf_read,
> .write_pcie = advk_pci_bridge_emul_pcie_conf_write,
> };
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-03-01 15:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-01 6:58 [PATCH -next] PCI: aardvark: Make symbol 'advk_pci_bridge_emul_ops' static Wei Yongjun
2019-03-01 7:25 ` Thomas Petazzoni
2019-03-01 15:29 ` Lorenzo Pieralisi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).