From: Sven Van Asbroeck <thesven73@gmail.com>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Sinan Kaya <okaya@kernel.org>,
Frederick Lawler <fred@fredlawl.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Keith Busch <keith.busch@intel.com>,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>
Subject: [PATCH v2] PCIE/PME: fix possible use-after-free on remove
Date: Fri, 1 Mar 2019 11:54:19 -0500 [thread overview]
Message-ID: <20190301165419.16493-1-TheSven73@gmail.com> (raw)
In remove(), ensure that the pme work cannot run after kfree()
is called. Otherwise, this could result in a use-after-free.
This issue was detected with the help of Coccinelle.
Cc: Sinan Kaya <okaya@kernel.org>
Cc: Frederick Lawler <fred@fredlawl.com>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Keith Busch <keith.busch@intel.com>
Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Sven Van Asbroeck <TheSven73@gmail.com>
---
drivers/pci/pcie/pme.c | 1 +
1 file changed, 1 insertion(+)
v2:
rebased against Bjorn Helgaas's pcm/pm branch at
git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git
diff --git a/drivers/pci/pcie/pme.c b/drivers/pci/pcie/pme.c
index efa5b552914b..54d593d10396 100644
--- a/drivers/pci/pcie/pme.c
+++ b/drivers/pci/pcie/pme.c
@@ -437,6 +437,7 @@ static void pcie_pme_remove(struct pcie_device *srv)
pcie_pme_disable_interrupt(srv->port, data);
free_irq(srv->irq, srv);
+ cancel_work_sync(&data->work);
kfree(data);
}
--
2.17.1
next reply other threads:[~2019-03-01 16:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-01 16:54 Sven Van Asbroeck [this message]
2019-03-02 0:11 ` [PATCH v2] PCIE/PME: fix possible use-after-free on remove Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190301165419.16493-1-TheSven73@gmail.com \
--to=thesven73@gmail.com \
--cc=bhelgaas@google.com \
--cc=fred@fredlawl.com \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=okaya@kernel.org \
--cc=rafael.j.wysocki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).