From: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>
To: marek.vasut@gmail.com
Cc: linux-pci@vger.kernel.org,
Marek Vasut <marek.vasut+renesas@gmail.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Phil Edworthy <phil.edworthy@renesas.com>,
Simon Horman <horms+renesas@verge.net.au>,
Wolfram Sang <wsa@the-dreams.de>,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH 1/2] PCI: rcar: Clean up remaining macros defining bits
Date: Sat, 9 Mar 2019 12:10:45 +0100 [thread overview]
Message-ID: <20190309111045.GB5281@bigcity.dyn.berto.se> (raw)
In-Reply-To: <20190309005613.1493-1-marek.vasut@gmail.com>
Hi Marek,
Thanks for your patch.
On 2019-03-09 01:56:12 +0100, Marek Vasut wrote:
> From: Marek Vasut <marek.vasut+renesas@gmail.com>
>
> Replace macros using constants with BIT()s instead, no functional change.
>
> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
> Cc: Phil Edworthy <phil.edworthy@renesas.com>
> Cc: Simon Horman <horms+renesas@verge.net.au>
> Cc: Wolfram Sang <wsa@the-dreams.de>
> Cc: linux-renesas-soc@vger.kernel.org
> To: linux-pci@vger.kernel.org
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> ---
> drivers/pci/controller/pcie-rcar.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/pci/controller/pcie-rcar.c b/drivers/pci/controller/pcie-rcar.c
> index c8febb009454..5b8736f0cd6b 100644
> --- a/drivers/pci/controller/pcie-rcar.c
> +++ b/drivers/pci/controller/pcie-rcar.c
> @@ -46,14 +46,14 @@
>
> /* Transfer control */
> #define PCIETCTLR 0x02000
> -#define CFINIT 1
> +#define CFINIT BIT(0)
> #define PCIETSTR 0x02004
> -#define DATA_LINK_ACTIVE 1
> +#define DATA_LINK_ACTIVE BIT(0)
> #define PCIEERRFR 0x02020
> #define UNSUPPORTED_REQUEST BIT(4)
> #define PCIEMSIFR 0x02044
> #define PCIEMSIALR 0x02048
> -#define MSIFE 1
> +#define MSIFE BIT(0)
> #define PCIEMSIAUR 0x0204c
> #define PCIEMSIIER 0x02050
>
> --
> 2.20.1
>
--
Regards,
Niklas Söderlund
next prev parent reply other threads:[~2019-03-09 11:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-09 0:56 [PATCH 1/2] PCI: rcar: Clean up remaining macros defining bits marek.vasut
2019-03-09 0:56 ` [PATCH 2/2] PCI: rcar: Replace unsigned long with u32 in register accessors marek.vasut
2019-03-09 11:14 ` Niklas Söderlund
2019-03-11 9:41 ` Geert Uytterhoeven
2019-03-16 23:59 ` Marek Vasut
2019-03-17 10:22 ` Geert Uytterhoeven
2019-03-17 22:50 ` Marek Vasut
2019-03-18 8:19 ` Geert Uytterhoeven
2019-03-21 3:20 ` Marek Vasut
2019-03-25 8:06 ` Geert Uytterhoeven
2019-03-25 11:36 ` Marek Vasut
2019-03-09 11:10 ` Niklas Söderlund [this message]
2019-03-11 9:32 ` [PATCH 1/2] PCI: rcar: Clean up remaining macros defining bits Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190309111045.GB5281@bigcity.dyn.berto.se \
--to=niklas.soderlund@ragnatech.se \
--cc=geert+renesas@glider.be \
--cc=horms+renesas@verge.net.au \
--cc=linux-pci@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=marek.vasut+renesas@gmail.com \
--cc=marek.vasut@gmail.com \
--cc=phil.edworthy@renesas.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).