From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34532C4360F for ; Sat, 9 Mar 2019 11:10:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 04B2B20868 for ; Sat, 9 Mar 2019 11:10:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ragnatech-se.20150623.gappssmtp.com header.i=@ragnatech-se.20150623.gappssmtp.com header.b="ePQCTPX3" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726233AbfCILKt (ORCPT ); Sat, 9 Mar 2019 06:10:49 -0500 Received: from mail-lf1-f67.google.com ([209.85.167.67]:43032 "EHLO mail-lf1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726164AbfCILKt (ORCPT ); Sat, 9 Mar 2019 06:10:49 -0500 Received: by mail-lf1-f67.google.com with SMTP id i13so169240lfg.10 for ; Sat, 09 Mar 2019 03:10:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ragnatech-se.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=2K/HDy9ejUSQlPnuCSMf/sE/kM0/YFTKnZJKNluqV5g=; b=ePQCTPX3TPE8pZ2lmmxmw36pciMcy8aYLXa4ucN/fw6j7Oslht3iE1LN9j/gauOp7L QYhSafMmXHRrkJCSbjSbALEzOLBrUaGv4580Uvn78pHpJNIujGl5OEF0ljkMz4Gg6VS9 dvp9SqZubuyZQqya1VhSUrz7yLI2rXQf5sCaFEQEBvQd6qF27CUxb9epbzuSUVc7IZga yWeEOlFdnyvLSO9tuEYiI+UXVdw3ymaQVktzKftBKSHvzTCEkhAXrJ9TLmGahtx8yP2H sA2nB39L+S4wgZ8Kfh6khovRhwur0xHmdzU/hLY6kV3AM8xa3R20jNhxyAHJmPpaIUWn wmhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=2K/HDy9ejUSQlPnuCSMf/sE/kM0/YFTKnZJKNluqV5g=; b=kvvnCQIZleyNMuWoNko4IBmeVOOuqseKdD0D+SyGdO2dmUs4xyxQ32keuNFD35o0FH BaTIyW1s5CoUVP2ev9n0j1+mm6bN2X6Gp2G1BSM5O7LX5jvGsOWUIPPpU74p1AJpwM1s L0MN22CqOpUexNlc7FjhWDSQamlnc9IuNSxArAn9GlOQuQUCSC/TTDrH7kB0N44jpNKE ze/SfEV27Zy8e1qA3CJyk2izW8GlnXjEzllxptOS1+KNm2eVGz8cxWkQZZUNgPRc8cQO KqM8knEmSKT0Z5r8ePvMdJSvM3pEgx9UbHGY+HRnER0Ii2ohbXuIAhbMAn4v9Df3ttFx 4EgA== X-Gm-Message-State: APjAAAWznqw/970RZogNwXkkLEYVbBy7mtwsyuKHkbR0jH4FKzLvq/t9 +DGvj6x2GR2+nySOe4eB24LToA== X-Google-Smtp-Source: APXvYqyl0XxO5cdiYLD3BJsN5uewHFYsXUk+EYIuv+HTZdtSgC+6un2OCJR5zm9nHKL+Si9n4sBlpw== X-Received: by 2002:a19:d4cf:: with SMTP id l198mr4385028lfg.151.1552129846872; Sat, 09 Mar 2019 03:10:46 -0800 (PST) Received: from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99]) by smtp.gmail.com with ESMTPSA id r12sm33334ljc.97.2019.03.09.03.10.46 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 09 Mar 2019 03:10:46 -0800 (PST) Date: Sat, 9 Mar 2019 12:10:45 +0100 From: Niklas =?iso-8859-1?Q?S=F6derlund?= To: marek.vasut@gmail.com Cc: linux-pci@vger.kernel.org, Marek Vasut , Geert Uytterhoeven , Phil Edworthy , Simon Horman , Wolfram Sang , linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH 1/2] PCI: rcar: Clean up remaining macros defining bits Message-ID: <20190309111045.GB5281@bigcity.dyn.berto.se> References: <20190309005613.1493-1-marek.vasut@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190309005613.1493-1-marek.vasut@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Hi Marek, Thanks for your patch. On 2019-03-09 01:56:12 +0100, Marek Vasut wrote: > From: Marek Vasut > > Replace macros using constants with BIT()s instead, no functional change. > > Signed-off-by: Marek Vasut > Cc: Geert Uytterhoeven > Cc: Phil Edworthy > Cc: Simon Horman > Cc: Wolfram Sang > Cc: linux-renesas-soc@vger.kernel.org > To: linux-pci@vger.kernel.org Reviewed-by: Niklas Söderlund > --- > drivers/pci/controller/pcie-rcar.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/pci/controller/pcie-rcar.c b/drivers/pci/controller/pcie-rcar.c > index c8febb009454..5b8736f0cd6b 100644 > --- a/drivers/pci/controller/pcie-rcar.c > +++ b/drivers/pci/controller/pcie-rcar.c > @@ -46,14 +46,14 @@ > > /* Transfer control */ > #define PCIETCTLR 0x02000 > -#define CFINIT 1 > +#define CFINIT BIT(0) > #define PCIETSTR 0x02004 > -#define DATA_LINK_ACTIVE 1 > +#define DATA_LINK_ACTIVE BIT(0) > #define PCIEERRFR 0x02020 > #define UNSUPPORTED_REQUEST BIT(4) > #define PCIEMSIFR 0x02044 > #define PCIEMSIALR 0x02048 > -#define MSIFE 1 > +#define MSIFE BIT(0) > #define PCIEMSIAUR 0x0204c > #define PCIEMSIIER 0x02050 > > -- > 2.20.1 > -- Regards, Niklas Söderlund