From: Bjorn Helgaas <helgaas@kernel.org>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Juergen Gross <jgross@suse.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
xen-devel@lists.xenproject.org, Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH] PCI: Mark expected switch fall-throughs
Date: Wed, 20 Mar 2019 14:24:54 -0500 [thread overview]
Message-ID: <20190320192454.GB251185@google.com> (raw)
In-Reply-To: <20190320182715.GA9406@embeddedor>
On Wed, Mar 20, 2019 at 01:27:15PM -0500, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch
> cases where we are expecting to fall through.
Does this fix all the remaining cases in drivers/pci? I'd like to fix
them all at once.
What's the best way to watch for new warnings being added? I fiddled
with "make W=2" etc but it didn't seem useful. Does the 0-day robot
warn when -Wimplicit-fallthrough warnings are added?
Bjorn
> This patch fixes the following warnings:
>
> drivers/pci/proc.c: In function ‘proc_bus_pci_ioctl’:
> drivers/pci/proc.c:216:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
> if (arch_can_pci_mmap_wc()) {
> ^
> drivers/pci/proc.c:225:2: note: here
> default:
> ^~~~~~~
>
> drivers/pci/xen-pcifront.c: In function ‘pcifront_backend_changed’:
> drivers/pci/xen-pcifront.c:1105:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
> if (xdev->state == XenbusStateClosed)
> ^
> drivers/pci/xen-pcifront.c:1108:2: note: here
> case XenbusStateClosing:
> ^~~~
>
> Notice that, in this particular case, the /* fall through */
> comment is placed at the very bottom of the case statement,
> which is what GCC is expecting to find.
>
> Warning level 3 was used: -Wimplicit-fallthrough=3
>
> This patch is part of the ongoing efforts to enable
> -Wimplicit-fallthrough.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> drivers/pci/proc.c | 1 +
> drivers/pci/xen-pcifront.c | 2 +-
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/pci/proc.c b/drivers/pci/proc.c
> index 6fa1627ce08d..445b51db75b0 100644
> --- a/drivers/pci/proc.c
> +++ b/drivers/pci/proc.c
> @@ -222,6 +222,7 @@ static long proc_bus_pci_ioctl(struct file *file, unsigned int cmd,
> }
> /* If arch decided it can't, fall through... */
> #endif /* HAVE_PCI_MMAP */
> + /* fall through */
> default:
> ret = -EINVAL;
> break;
> diff --git a/drivers/pci/xen-pcifront.c b/drivers/pci/xen-pcifront.c
> index eba6e33147a2..14cf0f41ecf0 100644
> --- a/drivers/pci/xen-pcifront.c
> +++ b/drivers/pci/xen-pcifront.c
> @@ -1104,7 +1104,7 @@ static void __ref pcifront_backend_changed(struct xenbus_device *xdev,
> case XenbusStateClosed:
> if (xdev->state == XenbusStateClosed)
> break;
> - /* Missed the backend's CLOSING state -- fallthrough */
> + /* fall through - Missed the backend's CLOSING state. */
> case XenbusStateClosing:
> dev_warn(&xdev->dev, "backend going away!\n");
> pcifront_try_disconnect(pdev);
> --
> 2.21.0
>
next prev parent reply other threads:[~2019-03-20 19:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-20 18:27 [PATCH] PCI: Mark expected switch fall-throughs Gustavo A. R. Silva
2019-03-20 19:24 ` Bjorn Helgaas [this message]
2019-03-20 19:33 ` Gustavo A. R. Silva
2019-03-20 19:27 ` [Xen-devel] " Andrew Cooper
2019-03-20 19:41 ` Gustavo A. R. Silva
2019-03-20 20:13 ` Bjorn Helgaas
2019-03-20 20:23 ` Gustavo A. R. Silva
2019-03-25 13:25 ` [Xen-devel] " Jan Beulich
-- strict thread matches above, loose matches on Subject: below --
2018-07-05 14:56 Gustavo A. R. Silva
2018-07-10 17:09 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190320192454.GB251185@google.com \
--to=helgaas@kernel.org \
--cc=boris.ostrovsky@oracle.com \
--cc=gustavo@embeddedor.com \
--cc=jgross@suse.com \
--cc=keescook@chromium.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).