From: Kishon Vijay Abraham I <kishon@ti.com>
To: Murali Karicheri <m-karicheri2@ti.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Gustavo Pimentel <gustavo.pimentel@synopsys.com>,
Marc Zyngier <marc.zyngier@arm.com>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
Jingoo Han <jingoohan1@gmail.com>, <linux-pci@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: [PATCH v5 0/8] PCI: DWC/Keystone: MSI configuration cleanup
Date: Thu, 21 Mar 2019 15:29:19 +0530 [thread overview]
Message-ID: <20190321095927.7058-1-kishon@ti.com> (raw)
This series tries to address the comments discussed in [1] w.r.t
removing Keystone specific callbacks defined in dw_pcie_host_ops.
This series also tries to cleanup the Keystone interrupt handling
part.
Changes from v4:
*) Removed legacy interrupt cleanup patch which uses hierarchy IRQ
domain since TI platform uses edge interrupt for legacy interrupt.
This will be deferred till I get more details from HW team.
Changes from v3:
*) Uses hierarchy IRQ domain for legacy interrupts since there is 1:1
mapping between legacy interrupt and GIC IRQ.
(MSI still depends on the order of IRQs populated in dt).
Changes from v2:
*) Removed patch that modifies ks_pcie_legacy_irq_handler() to check the
IRQ_STATUS of INTA/B/C/D. Lorenzo's comment to create a matrix
LinuxIRQ x INTx will be added in AM654x PCIe support series
*) ks_pcie_legacy_irq_handler() is made to use hwirq to get IRQ offset
instead of virq.
*) default msi_irq_chip is assigned in dw_pcie_host_init() once keystone
assigns its msi_irq_chip
*) Fixed other minor comments from Lorenzo and Bjorn
Changes from v1:
*) Removed "PCI: keystone: Use "dummy_irq_chip" instead of new irqchip
for legacy interrupt handling" from the patch series. It should be
handled differently.
*) Added Gustavo's ACKed by and fixed a commit message.
[1] -> https://patchwork.kernel.org/patch/10681587/
Kishon Vijay Abraham I (8):
PCI: keystone: Cleanup interrupt related macros
PCI: keystone: Add separate functions for configuring MSI and legacy
interrupt
PCI: keystone: Use hwirq to get the MSI IRQ number offset
PCI: keystone: Cleanup ks_pcie_msi_irq_handler
PCI: dwc: Add support to use non default msi_irq_chip
PCI: keystone: Use Keystone specific msi_irq_chip
PCI: dwc: Remove Keystone specific dw_pcie_host_ops
PCI: dwc: Do not write to MSI control registers if the platform
doesn't use it
drivers/pci/controller/dwc/pci-keystone.c | 365 ++++++++++--------
.../pci/controller/dwc/pcie-designware-host.c | 78 ++--
drivers/pci/controller/dwc/pcie-designware.h | 6 +-
3 files changed, 233 insertions(+), 216 deletions(-)
--
2.17.1
next reply other threads:[~2019-03-21 10:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-21 9:59 Kishon Vijay Abraham I [this message]
2019-03-21 9:59 ` [PATCH v5 1/8] PCI: keystone: Cleanup interrupt related macros Kishon Vijay Abraham I
2019-03-21 9:59 ` [PATCH v5 2/8] PCI: keystone: Add separate functions for configuring MSI and legacy interrupt Kishon Vijay Abraham I
2019-03-21 9:59 ` [PATCH v5 3/8] PCI: keystone: Use hwirq to get the MSI IRQ number offset Kishon Vijay Abraham I
2019-03-21 9:59 ` [PATCH v5 4/8] PCI: keystone: Cleanup ks_pcie_msi_irq_handler Kishon Vijay Abraham I
2019-03-21 9:59 ` [PATCH v5 5/8] PCI: dwc: Add support to use non default msi_irq_chip Kishon Vijay Abraham I
2019-03-21 9:59 ` [PATCH v5 6/8] PCI: keystone: Use Keystone specific msi_irq_chip Kishon Vijay Abraham I
2019-03-21 9:59 ` [PATCH v5 7/8] PCI: dwc: Remove Keystone specific dw_pcie_host_ops Kishon Vijay Abraham I
2019-03-21 9:59 ` [PATCH v5 8/8] PCI: dwc: Do not write to MSI control registers if the platform doesn't use it Kishon Vijay Abraham I
2019-04-03 17:19 ` Lorenzo Pieralisi
2019-04-04 7:42 ` Kishon Vijay Abraham I
2019-04-03 17:11 ` [PATCH v5 0/8] PCI: DWC/Keystone: MSI configuration cleanup Lorenzo Pieralisi
2019-04-10 16:50 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190321095927.7058-1-kishon@ti.com \
--to=kishon@ti.com \
--cc=bhelgaas@google.com \
--cc=gustavo.pimentel@synopsys.com \
--cc=jingoohan1@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=m-karicheri2@ti.com \
--cc=marc.zyngier@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).