From: Bjorn Helgaas <helgaas@kernel.org>
To: Jean-Philippe Brucker <jean-philippe.brucker@arm.com>
Cc: "robh+dt@kernel.org" <robh+dt@kernel.org>,
Mark Rutland <Mark.Rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
Jeremy Linton <Jeremy.Linton@arm.com>,
Grant Likely <Grant.Likely@arm.com>,
Robin Murphy <Robin.Murphy@arm.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/2] dt-bindings: Add external-facing PCIe port property
Date: Mon, 25 Mar 2019 08:53:12 -0500 [thread overview]
Message-ID: <20190325135312.GQ251185@google.com> (raw)
In-Reply-To: <598b0675-38b2-9e52-d903-016dc548756c@arm.com>
On Mon, Mar 25, 2019 at 12:59:48PM +0000, Jean-Philippe Brucker wrote:
> On 20/03/2019 22:03, Bjorn Helgaas wrote:
> > On Mon, Mar 18, 2019 at 06:21:23PM +0000, Jean-Philippe Brucker wrote:
> >> +- external-facing:
> >> + When present, the port is external facing. All bridges and endpoints
> >> + downstream of this port are external to the machine.
> >
> > Maybe include a note about why this is important, ie, we care because
> > malicious devices may be attached to an external port? I know you
> > have that in the commit log but it would be more visible here.
> >
> > Elsewhere you use "external-facing", here too for consistency?
>
> Makes sense, I'll add a note. I currently have:
>
> - external-facing:
> When present, the port is external-facing. All bridges and endpoints
> downstream of this port are external to the machine. The OS can, for
> example, use this information to identify devices that cannot be
> trusted with relaxed DMA protection, as users could easily attach
> malicious devices to this port.
Looks good to me!
next prev parent reply other threads:[~2019-03-25 13:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-18 18:21 [PATCH 0/2] PCI: Describe external-facing ports in device tree Jean-Philippe Brucker
2019-03-18 18:21 ` [PATCH 1/2] dt-bindings: Add external-facing PCIe port property Jean-Philippe Brucker
2019-03-20 22:03 ` Bjorn Helgaas
2019-03-25 12:59 ` Jean-Philippe Brucker
2019-03-25 13:53 ` Bjorn Helgaas [this message]
2019-03-18 18:21 ` [PATCH 2/2] PCI: OF: Support external-facing property Jean-Philippe Brucker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190325135312.GQ251185@google.com \
--to=helgaas@kernel.org \
--cc=Grant.Likely@arm.com \
--cc=Jeremy.Linton@arm.com \
--cc=Mark.Rutland@arm.com \
--cc=Robin.Murphy@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=jean-philippe.brucker@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).