From: kbuild test robot <lkp@intel.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: kbuild-all@01.org, linux-pci@vger.kernel.org
Subject: [RFC PATCH pci] nvme-pci: nvme_rescan_prepare() can be static
Date: Tue, 26 Mar 2019 23:37:57 +0800 [thread overview]
Message-ID: <20190326153756.GA108234@lkp-hsx02> (raw)
In-Reply-To: <201903262317.Xf94y2xJ%lkp@intel.com>
Fixes: aad30cad0869 ("nvme-pci: Handle movable BARs")
Signed-off-by: kbuild test robot <lkp@intel.com>
---
pci.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index ec1461e..6575fe6 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -2916,7 +2916,7 @@ static void nvme_error_resume(struct pci_dev *pdev)
flush_work(&dev->ctrl.reset_work);
}
-void nvme_rescan_prepare(struct pci_dev *pdev)
+static void nvme_rescan_prepare(struct pci_dev *pdev)
{
struct nvme_dev *dev = pci_get_drvdata(pdev);
@@ -2925,7 +2925,7 @@ void nvme_rescan_prepare(struct pci_dev *pdev)
dev->bar = NULL;
}
-void nvme_rescan_done(struct pci_dev *pdev)
+static void nvme_rescan_done(struct pci_dev *pdev)
{
struct nvme_dev *dev = pci_get_drvdata(pdev);
next prev parent reply other threads:[~2019-03-26 15:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-26 15:37 [pci:review/pci/resource 8/21] drivers/nvme/host/pci.c:2919:6: sparse: symbol 'nvme_rescan_prepare' was not declared. Should it be static? kbuild test robot
2019-03-26 15:37 ` kbuild test robot [this message]
2019-03-26 15:40 ` Christoph Hellwig
2019-03-26 17:35 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190326153756.GA108234@lkp-hsx02 \
--to=lkp@intel.com \
--cc=helgaas@kernel.org \
--cc=kbuild-all@01.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).