On Mon, Apr 15, 2019 at 09:00:58PM +0530, Manikanta Maddireddy wrote:
> 
> 
> On 15-Apr-19 7:07 PM, Thierry Reding wrote:
> > On Thu, Apr 11, 2019 at 10:33:46PM +0530, Manikanta Maddireddy wrote:
> >> Each root port is added as a child device tree node of PCIe controller
> >> node. These child nodes are parsed using open firmware PCI bus accessor
> >> functions. If the child node is not of "pci" type then device tree
> >> parsing fails. Add "pci" type check before parsing child device tree node.
> >>
> >> Signed-off-by: Manikanta Maddireddy <mmaddireddy@nvidia.com>
> >> ---
> >>  drivers/pci/controller/pci-tegra.c | 3 +++
> >>  1 file changed, 3 insertions(+)
> > Erm... what is the use-case that you're trying to support? Why would we
> > ever have children nodes that are not of type "pci"?
> >
> > Thierry
> In downstream kernel we have "prod-settings" node as one of the child nodes.
> Even though we are not supporting this in upstream kernel, I believe this
> check is good to have.

We don't have prod-settings upstream and for good reason. There's no
need to add this check in upstream. We can carry the change downstream
until we've moved away from prod-settings downstream as well.

Thierry