From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 951C3C282DA for ; Wed, 17 Apr 2019 21:54:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 61E6321850 for ; Wed, 17 Apr 2019 21:54:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1555538064; bh=72Y5yaN0OBfC9mUcvHjlGNLJip4pGYju/K0LqKwOLwc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=JCPhaJ5wBvJXlkyOJE3wOiQdlM9Txd01Ydv12qHpfLT4M24yb6vx/lml+icc10H9U edEk8mOgtXFDFrqGXmuiwGodBh1eyav34MZue0lBV3Uvi7hf8WeLffBTGq6mYaMrQ7 nEHJLoVJ9p4U5MCo8V433BtqpFP6G0IQ2a5Sk7pE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729500AbfDQVyX (ORCPT ); Wed, 17 Apr 2019 17:54:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:60898 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727013AbfDQVyX (ORCPT ); Wed, 17 Apr 2019 17:54:23 -0400 Received: from localhost (unknown [69.71.4.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 02D132183E; Wed, 17 Apr 2019 21:54:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1555538062; bh=72Y5yaN0OBfC9mUcvHjlGNLJip4pGYju/K0LqKwOLwc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DYyFEOoGarNIlIT1PXcglispXnZEI28ZJKPVL8PDwblSBxon5P0mdc8YFX8tDVIeE ao3gUQRABJs/t6Px3rca2tptluOmgl2aizC1AX7DxR79MlaIzFdSNmrrsPl8YBp4QC zRssT3BQEez1cOz0oqeFOWgKY3xNb+UyDDuaduWw= Date: Wed, 17 Apr 2019 16:54:20 -0500 From: Bjorn Helgaas To: Julia Lawall Cc: Sebastian Andrzej Siewior , kbuild-all@01.org, Kurt Schwemmer , Logan Gunthorpe , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Kirill Smelkov Subject: Re: [PATCH] pci/switchtec: fix stream_open.cocci warnings (fwd) Message-ID: <20190417215420.GV126710@google.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Sat, Apr 13, 2019 at 06:50:57PM +0200, Julia Lawall wrote: > Hello, > > Kirill will explain about this issue. > > julia > > ---------- Forwarded message ---------- > Date: Sat, 13 Apr 2019 11:22:51 +0800 > From: kbuild test robot > To: kbuild@01.org > Cc: Julia Lawall > Subject: [PATCH] pci/switchtec: fix stream_open.cocci warnings > > CC: kbuild-all@01.org > TO: Sebastian Andrzej Siewior > CC: Kurt Schwemmer > CC: Logan Gunthorpe > CC: Bjorn Helgaas > CC: linux-pci@vger.kernel.org > CC: linux-kernel@vger.kernel.org > > From: kbuild test robot > > drivers/pci/switch/switchtec.c:395:1-17: ERROR: switchtec_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix. > > Generated by: scripts/coccinelle/api/stream_open.cocci > > Fixes: 8a29a3bae2a2 ("pci/switchtec: Don't use completion's wait queue") > Signed-off-by: kbuild test robot Based on Kirill's subsequent email saying this is already queued to the merge window, I assume I need to do nothing here. I think a signed-off-by from a robot, i.e., not from a real person, is meaningless, and I don't think I would personally accept it. It's certainly OK to indicate that a patch was auto-generated, but I think a real person still needs to take responsibility for it. Documentation/process/submitting-patches.rst says it must contain a real name (no pseudonyms or anonymous contributions), and I don't think a robot fits in the spirit of that. I see that https://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-rt-devel.git/commit/?id=8a29a3bae2a2 (mentioned below) does have a good signed-off-by from Sebastian, but that's not *this* patch, so I don't know what's what. Bjorn > --- > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-rt-devel.git linux-5.0.y-rt-rebase > head: 794c294ae4483c240429c25a0d18e272e92c94de > commit: 8a29a3bae2a2dfb0116cd8791d9700515d6e765e [154/311] pci/switchtec: Don't use completion's wait queue > :::::: branch date: 7 hours ago > :::::: commit date: 7 hours ago > > Please take the patch only if it's a positive warning. Thanks! > > switchtec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/drivers/pci/switch/switchtec.c > +++ b/drivers/pci/switch/switchtec.c > @@ -392,7 +392,7 @@ static int switchtec_dev_open(struct ino > return PTR_ERR(stuser); > > filp->private_data = stuser; > - nonseekable_open(inode, filp); > + stream_open(inode, filp); > > dev_dbg(&stdev->dev, "%s: %p\n", __func__, stuser); >