From: Bjorn Helgaas <helgaas@kernel.org>
To: James Prestwood <james.prestwood@linux.intel.com>,
Alex Williamson <alex.williamson@redhat.com>
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH] PCI: quirks: add vendor ID for AR9462 card
Date: Fri, 19 Apr 2019 08:45:45 -0500 [thread overview]
Message-ID: <20190419134545.GB173520@google.com> (raw)
In-Reply-To: <20190107213248.3034-1-james.prestwood@linux.intel.com>
On Mon, Jan 07, 2019 at 01:32:48PM -0800, James Prestwood wrote:
> This card has similar issues with bus reset as the others present in
> this list.
>
> Signed-off-by: James Prestwood <james.prestwood@linux.intel.com>
Alex, I'm inclined to apply this unless you object because it's
basically one more of something we already do. I wish we didn't have
this quirk at all, but I don't know what else to do.
Maybe there's someplace we could add a printk so dmesg contains a clue
that we can't reset the device? I assume this quirk means we can't
reset the device when we otherwise would, so maybe that means this
device will leak state from one VM to another? That sounds like
something we would want to surface somehow if we don't already.
Bjorn
> ---
> drivers/pci/quirks.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> index ef7143a274e0..d9d4a95b0309 100644
> --- a/drivers/pci/quirks.c
> +++ b/drivers/pci/quirks.c
> @@ -3379,6 +3379,7 @@ DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_ATHEROS, 0x0030, quirk_no_bus_reset);
> DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_ATHEROS, 0x0032, quirk_no_bus_reset);
> DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_ATHEROS, 0x003c, quirk_no_bus_reset);
> DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_ATHEROS, 0x0033, quirk_no_bus_reset);
> +DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_ATHEROS, 0x0034, quirk_no_bus_reset);
>
> /*
> * Root port on some Cavium CN8xxx chips do not successfully complete a bus
> --
> 2.17.1
>
next prev parent reply other threads:[~2019-04-19 18:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-07 21:32 [PATCH] PCI: quirks: add vendor ID for AR9462 card James Prestwood
2019-01-07 22:08 ` Bjorn Helgaas
2019-01-07 23:02 ` James Prestwood
2019-04-19 13:45 ` Bjorn Helgaas [this message]
2019-04-23 20:38 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190419134545.GB173520@google.com \
--to=helgaas@kernel.org \
--cc=alex.williamson@redhat.com \
--cc=james.prestwood@linux.intel.com \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).