From: Bjorn Helgaas <helgaas@kernel.org>
To: Alexandru Gagniuc <mr.nuke.me@gmail.com>,
Lukas Wunner <lukas@wunner.de>,
Alex Williamson <alex.williamson@redhat.com>,
Austin Bolen <austin_bolen@dell.com>,
Alexandru Gagniuc <alex_gagniuc@dellteam.com>,
Keith Busch <keith.busch@intel.com>,
Shyam Iyer <Shyam_Iyer@dell.com>, Sinan Kaya <okaya@kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] Revert "PCI/LINK: Report degraded links via link bandwidth
Date: Mon, 29 Apr 2019 13:56:10 -0500 [thread overview]
Message-ID: <20190429185611.121751-1-helgaas@kernel.org> (raw)
Alex W. reported a case where the new link bandwidth notification logging,
e.g.:
vfio-pci 0000:07:00.0: 32.000 Gb/s available PCIe bandwidth, limited by 2.5 GT/s x16 link at 0000:00:02.0 (capable of 64.000 Gb/s with 5 GT/s x16 link)
is somewhat surprising. The message is great if link bandwidth was reduced
because of a hardware problem, but in this case it's caused by a GPU doing
link state management to conserve power, so the message is to be expected
and is likely to confuse the user.
We haven't figured out a good way to handle both the "hardware failure" and
the "active link management" cases yet, so revert this for now.
Bjorn
next reply other threads:[~2019-04-29 18:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-29 18:56 Bjorn Helgaas [this message]
2019-04-29 18:56 ` [PATCH] Revert "PCI/LINK: Report degraded links via link bandwidth notification" Bjorn Helgaas
2019-04-29 19:21 ` Alex Williamson
2019-04-30 1:07 ` Alex G
2019-04-30 16:11 ` Bjorn Helgaas
2019-04-30 18:05 ` Keith Busch
2019-04-30 18:18 ` Keith Busch
2019-05-01 2:12 ` Bjorn Helgaas
2019-05-01 13:16 ` Keith Busch
2019-04-30 23:09 ` Lukas Wunner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190429185611.121751-1-helgaas@kernel.org \
--to=helgaas@kernel.org \
--cc=Shyam_Iyer@dell.com \
--cc=alex.williamson@redhat.com \
--cc=alex_gagniuc@dellteam.com \
--cc=austin_bolen@dell.com \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=mr.nuke.me@gmail.com \
--cc=okaya@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).