Re: [PATCH 03/10] PCI/DPC: Log messages with pci_dev, not pcie_device

From: Bjorn Helgaas <helgaas@kernel.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Frederick Lawler <fred@fredlawl.com>,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	Lukas Wunner <lukas@wunner.de>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Keith Busch <keith.busch@intel.com>,
	Dongdong Liu <liudongdong3@huawei.com>,
	Sven Van Asbroeck <thesven73@gmail.com>,
	linux-pci@vger.kernel.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 03/10] PCI/DPC: Log messages with pci_dev, not pcie_device
Date: Thu, 9 May 2019 16:18:58 -0500	[thread overview]
Message-ID: <20190509211858.GD235064@google.com> (raw)
In-Reply-To: <CAHp75Vd=fm4Sdc_ymiPgXnrCsU_9gBF16TsP0VX=ghDrbvk1Yw@mail.gmail.com>

On Thu, May 09, 2019 at 08:39:28PM +0300, Andy Shevchenko wrote:
> On Thu, May 9, 2019 at 5:18 PM Bjorn Helgaas <helgaas@kernel.org> wrote:
> > Log messages with pci_dev, not pcie_device.  Factor out common message
> > prefixes with dev_fmt().
> >
> > Example output change:
> >
> >   - dpc 0000:00:01.1:pcie008: DPC error containment capabilities...
> >   + pcieport 0000:00:01.1: DPC: error containment capabilities...
> 
> Overall same question about Capitalizing sentences.

I think that consistency would be nice.  But I'm not sure whether the
consensus is capitalize or not, and I would want to do all of
drivers/pci in a single patch so there's a clear precedent to follow,
so I think that's slightly out of scope for this series.

> > +       pci_err(pdev, "rp_pio_status: %#010x, rp_pio_mask: %#010x\n",
> 
> And here perhaps RP PIO status: ... mask: ... ?
> See below I left examples from this patch.

Same thing here.  I noticed this as well, but didn't want to pollute
these patches with other cleanups that were not really related, so
this could be done in the future.  But I certainly agree it's weird to
have "rp_pio_status:" and "RP PIO severity=".

> >                 status, mask);
> 
> > +       pci_err(pdev, "RP PIO severity=%#010x, syserror=%#010x, exception=%#010x\n",
> >                 sev, syserr, exc);
> 
> > +       pci_err(pdev, "RP PIO ImpSpec Log %#010x\n", log);
> 
> > +                       pci_err(pdev, "RP PIO log size %u is invalid\n",
> >                                 dpc->rp_log_size);
> 
> -- 
> With Best Regards,
> Andy Shevchenko