From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E557BC04A6B for ; Fri, 10 May 2019 14:34:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C3CD2217D6 for ; Fri, 10 May 2019 14:34:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727974AbfEJOeU (ORCPT ); Fri, 10 May 2019 10:34:20 -0400 Received: from mga14.intel.com ([192.55.52.115]:32461 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727248AbfEJOeT (ORCPT ); Fri, 10 May 2019 10:34:19 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 May 2019 07:34:16 -0700 X-ExtLoop1: 1 Received: from smile.fi.intel.com (HELO smile) ([10.237.72.86]) by orsmga002.jf.intel.com with ESMTP; 10 May 2019 07:34:08 -0700 Received: from andy by smile with local (Exim 4.92) (envelope-from ) id 1hP6b9-0004Sg-Pc; Fri, 10 May 2019 17:34:07 +0300 Date: Fri, 10 May 2019 17:34:07 +0300 From: "andriy.shevchenko@linux.intel.com" To: "Ardelean, Alexandru" Cc: "gregkh@linuxfoundation.org" , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-ide@vger.kernel.org" , "linux-usb@vger.kernel.org" , "linux-mmc@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "cgroups@vger.kernel.org" , "intel-gfx@lists.freedesktop.org" , "linux-pm@vger.kernel.org" , "linux-mm@kvack.org" , "linux-omap@vger.kernel.org" , "linux-gpio@vger.kernel.org" , "linux-security-module@vger.kernel.org" , "devel@driverdev.osuosl.org" , "linux-integrity@vger.kernel.org" , "linux-fbdev@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "linux-rpi-kernel@lists.infradead.org" , "linux-arm-kernel@lists.infradead.org" , "netdev@vger.kernel.org" , "alsa-devel@alsa-project.org" , "linux-rockchip@lists.infradead.org" , "linux-clk@vger.kernel.org" , "linux-pci@vger.kernel.org" , "linux-wireless@vger.kernel.org" , "linux-mtd@lists.infradead.org" , "linux-tegra@vger.kernel.org" Subject: Re: [PATCH 03/16] lib,treewide: add new match_string() helper/macro Message-ID: <20190510143407.GA9224@smile.fi.intel.com> References: <20190508112842.11654-1-alexandru.ardelean@analog.com> <20190508112842.11654-5-alexandru.ardelean@analog.com> <20190508131128.GL9224@smile.fi.intel.com> <20190508131856.GB10138@kroah.com> <4df165bc4247e60aa4952fd55cb0c77e60712767.camel@analog.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4df165bc4247e60aa4952fd55cb0c77e60712767.camel@analog.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Fri, May 10, 2019 at 09:15:27AM +0000, Ardelean, Alexandru wrote: > On Wed, 2019-05-08 at 16:22 +0300, Alexandru Ardelean wrote: > > On Wed, 2019-05-08 at 15:18 +0200, Greg KH wrote: > > > On Wed, May 08, 2019 at 04:11:28PM +0300, Andy Shevchenko wrote: > > > > On Wed, May 08, 2019 at 02:28:29PM +0300, Alexandru Ardelean wrote: > > > > Can you split include/linux/ change from the rest? > > > > > > That would break the build, why do you want it split out? This makes > > > sense all as a single patch to me. > > > > > > > Not really. > > It would be just be the new match_string() helper/macro in a new commit. > > And the conversions of the simple users of match_string() (the ones using > > ARRAY_SIZE()) in another commit. > > > > I should have asked in my previous reply. > Leave this as-is or re-formulate in 2 patches ? Depends on on what you would like to spend your time: collecting Acks for all pieces in treewide patch or send new API first followed up by per driver / module update in next cycle. I also have no strong preference. And I think it's good to add Heikki Krogerus to Cc list for both patch series, since he is the author of sysfs variant and may have something to comment on the rest. -- With Best Regards, Andy Shevchenko