From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 702E8C31E4B for ; Fri, 14 Jun 2019 15:23:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 45FE72133D for ; Fri, 14 Jun 2019 15:23:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725991AbfFNPXn (ORCPT ); Fri, 14 Jun 2019 11:23:43 -0400 Received: from foss.arm.com ([217.140.110.172]:36598 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725981AbfFNPXn (ORCPT ); Fri, 14 Jun 2019 11:23:43 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B2E62344; Fri, 14 Jun 2019 08:23:42 -0700 (PDT) Received: from e121166-lin.cambridge.arm.com (unknown [10.1.196.255]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id AE3D43F718; Fri, 14 Jun 2019 08:23:41 -0700 (PDT) Date: Fri, 14 Jun 2019 16:23:36 +0100 From: Lorenzo Pieralisi To: Yuehaibing Cc: bhelgaas@google.com, sthemmin@microsoft.com, sashal@kernel.org, decui@microsoft.com, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org Subject: Re: [PATCH] PCI: hv: Fix build error without CONFIG_SYSFS Message-ID: <20190614152336.GA26846@e121166-lin.cambridge.arm.com> References: <20190531150923.12376-1-yuehaibing@huawei.com> <6c97b2ae-b151-5610-d8d5-ef626d1f9bbb@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6c97b2ae-b151-5610-d8d5-ef626d1f9bbb@huawei.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Fri, Jun 14, 2019 at 10:19:10PM +0800, Yuehaibing wrote: > Hi all, > > Friendly ping... We should address Michael's question: https://lore.kernel.org/linux-pci/BYAPR21MB12211EEA95200F437C8E37ECD71A0@BYAPR21MB1221.namprd21.prod.outlook.com/ Lorenzo > On 2019/5/31 23:09, YueHaibing wrote: > > while building without CONFIG_SYSFS, fails as below: > > > > drivers/pci/controller/pci-hyperv.o: In function 'hv_pci_assign_slots': > > pci-hyperv.c:(.text+0x40a): undefined reference to 'pci_create_slot' > > drivers/pci/controller/pci-hyperv.o: In function 'pci_devices_present_work': > > pci-hyperv.c:(.text+0xc02): undefined reference to 'pci_destroy_slot' > > drivers/pci/controller/pci-hyperv.o: In function 'hv_pci_remove': > > pci-hyperv.c:(.text+0xe50): undefined reference to 'pci_destroy_slot' > > drivers/pci/controller/pci-hyperv.o: In function 'hv_eject_device_work': > > pci-hyperv.c:(.text+0x11f9): undefined reference to 'pci_destroy_slot' > > > > Select SYSFS while PCI_HYPERV is set to fix this. > > > > Reported-by: Hulk Robot > > Fixes: a15f2c08c708 ("PCI: hv: support reporting serial number as slot information") > > Signed-off-by: YueHaibing > > --- > > drivers/pci/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/pci/Kconfig b/drivers/pci/Kconfig > > index 2ab9240..6722952 100644 > > --- a/drivers/pci/Kconfig > > +++ b/drivers/pci/Kconfig > > @@ -182,6 +182,7 @@ config PCI_LABEL > > config PCI_HYPERV > > tristate "Hyper-V PCI Frontend" > > depends on X86 && HYPERV && PCI_MSI && PCI_MSI_IRQ_DOMAIN && X86_64 > > + select SYSFS > > help > > The PCI device frontend driver allows the kernel to import arbitrary > > PCI devices from a PCI backend to support PCI driver domains. > > >